Fixing the incorrect error code even when CLI exits correctly

[abhishekkumams]

Why make this change?

• Closes Incorrect Error code with dab cli #1150
  • ErrorCode -1 is being returned when a command other than specified in dab is used, like --version, --help

What is this change?

• Options --help generates ErrorType.HelpRequestedError and ErrorType.HelpVerbRequestedError while --version generates ErrorType.VersionRequestedError.
• While parsing we specifically looked if these error types are produced and marked them with exit code 0.

How was this tested?

• manually
• unit tests

Sample Request(s)

[Aniruddh25]

some questions

[Aniruddh25]

Any error to perform init etc should result in -1 exit code.

[Aniruddh25]

dab --version

last exit code should be 0.

[seantleonard]

nit

[abhishekkumams]

well, I'll create a separate issue to expand the scope, so that it gives -1 for any kind of errors (like validation errors, parsing errors, etc). Keeping in view the release, we should get this in, as swa cli team uses only dab --version to check if dab is installed or not, or if it's on the latest version. Issue: #1162

[Aniruddh25]

well, I'll create a separate issue to expand the scope, so that it gives -1 for any kind of errors (like validation errors, parsing errors, etc). Keeping in view the release, we should get this in, as swa cli team uses only dab --version to check if dab is installed or not, or if it's on the latest version. Issue: #1162

Even if we don't expand the scope now, by removing isParsed we are regressing the existing functionality, where we return -1 if the parsed object is not a recognized command for e.g. edit.
I think we should explicitly checking for version and help as one of the supported commands, return 0 for those and retain existing functionality - no regressions.

[abhishekkumams]

There has been an issue created for System.CommandLine as to understand why --help and --version are considered as error.
Ref: commandlineparser/commandline#630

I'll use the workaround for --help and --version

[seantleonard]

Thanks for this update and making sure no regressions occur. Also appreciate your documenting commandline package behavior to justify and design your workaround!