Skip to content

Fixing the incorrect error code even when CLI exits correctly #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 2, 2023
Merged

Fixing the incorrect error code even when CLI exits correctly #1151

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
616d601
making the main method in CLI void
abhishekkumams Jan 31, 2023
cafa4f4
Merge branch 'main' into dev/abhishekkuma/fix-incorrect-error-code-wi…
abhishekkumams Feb 1, 2023
253d5ab
Update src/Cli/src/Program.cs
abhishekkumams Feb 1, 2023
bd14fca
Merge branch 'main' into dev/abhishekkuma/fix-incorrect-error-code-wi…
Aniruddh25 Feb 1, 2023
bf372ed
Merge branch 'main' into dev/abhishekkuma/fix-incorrect-error-code-wi…
abhishekkumams Feb 2, 2023
66b225c
Merge branch 'main' into dev/abhishekkuma/fix-incorrect-error-code-wi…
abhishekkumams Feb 2, 2023
1183753
fixing exit code for --help and --version
abhishekkumams Feb 2, 2023
7f58bc2
Merge branch 'dev/abhishekkuma/fix-incorrect-error-code-with-dab-cli'…
abhishekkumams Feb 2, 2023
7179fce
fix formatting
abhishekkumams Feb 2, 2023
21b29bb
update comments
abhishekkumams Feb 2, 2023
0c036d5
removing redundant changes
abhishekkumams Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Cli/src/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ public class Program
/// Main CLI entry point
/// </summary>
/// <param name="args">CLI arguments</param>
/// <returns>0 on success, -1 on failure.</returns>
public static int Main(string[] args)
public static void Main(string[] args)
{
Parser parser = new(settings =>
{
Expand Down Expand Up @@ -102,7 +101,6 @@ public static int Main(string[] args)
}
});

return result is Parsed<object> ? 0 : -1;
}

/// <summary>
Expand Down