Skip to content

[msal-common] End-to-end common code works for msal-browser and msal-node #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
sameerag opened this issue Apr 10, 2020 · 1 comment
Closed
3 tasks

[msal-common] End-to-end common code works for msal-browser and msal-node #1492

sameerag opened this issue Apr 10, 2020 · 1 comment
Labels
internal Issues created by MSAL.js team for internal tracking.

Comments

@sameerag
Copy link
Member

Upcoming Library

Type

  • Enhancement

Source

  • Internal (MSAL.js team)

Description

msal-common is fractured for msal-node and msal-browser during the development phase. This PR is to fold the code for both libraries and ensure it works. This includes:

  • Configuration
  • Request
  • Response
  • Cache

Priority

May end

Acceptance Criteria

  1. Samples and Unit tests pass for msal-browser and msal-node
  2. npm versions reflect same msal-common for both libraries
@sameerag sameerag added the internal Issues created by MSAL.js team for internal tracking. label Apr 10, 2020
@sameerag
Copy link
Member Author

sameerag commented Jul 2, 2020 •
edited
Loading

The below PRs enabled msal-common cache functionality to work for msal-node and msal-browser:

PR Description Status
#1711 [msal-node][#1] SilentFlow support in msal-common Completed
#1762 [msal-node][#2] Merge cache logic in msal-common for node and browser platforms Completed
#1770 [msal-common family][#3] Utilize ScopeSet across the library Completed
#1771 [msal-common][msal-node][#4] Update UnifiedCacheManager.ts Completed

@sameerag sameerag closed this as completed Jul 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
internal Issues created by MSAL.js team for internal tracking.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sameerag