Skip to content

[msal-common family][#3] Utilize ScopeSet across the library #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 18, 2020
Merged

[msal-common family][#3] Utilize ScopeSet across the library #1770

merged 12 commits into from
Jun 18, 2020

Conversation

pkanher617
Copy link
Contributor

@pkanher617 pkanher617 commented Jun 11, 2020 •
edited
Loading

This PR does the following:

  • Removes scopeRequired from ScopeSet
  • Always adds openid and profile to all requests
  • Using containsScopeSet and intersectingScopeSets in the UnifiedCacheManager
  • Add browser maintenance code
  • Adds fromCache to the AuthenticationResult
  • Adds nonce check to the ResponseHandler.ts

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library. labels Jun 11, 2020
@pkanher617 pkanher617 changed the title [msal-common family] Utilize ScopeSet across the library [msal-common family][#3] Utilize ScopeSet across the library Jun 11, 2020
sangonzal
sangonzal suggested changes Jun 17, 2020
View reviewed changes
lib/msal-node/src/client/ClientApplication.ts Outdated
* Generates a request with the default scopes.
* @param request
*/
protected generateUrlRequest(request: AuthorizationUrlRequest): AuthorizationUrlRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not duplicate this code here (ln 134-175) and device code request in PublicClientApplication.

Consider creating ScopeSet and passing in as part of ClientConfiguration or creating a parent class for requests.

@pkanher617 pkanher617 changed the base branch from msal-node-cache-merge to dev June 17, 2020 22:55
sangonzal
sangonzal approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tnorling
tnorling approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 77.874% when pulling 8057856 on msal-common-scopeset-update into c968ef7 on dev.

sameerag
sameerag approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pkanher617 pkanher617 merged commit a42591f into dev Jun 18, 2020
@pkanher617 pkanher617 mentioned this pull request Jun 24, 2020
Closed
8 tasks
@sameerag sameerag mentioned this pull request Jun 24, 2020
Closed
1 task
@sameerag sameerag mentioned this pull request Jul 2, 2020
Closed
3 tasks
@pkanher617 pkanher617 deleted the msal-common-scopeset-update branch August 1, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@sangonzal sangonzal sangonzal approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jasonnutter jasonnutter Awaiting requested review from jasonnutter

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pkanher617 @coveralls @tnorling @sameerag @sangonzal