Skip to content

[msal-node][#1] SilentFlow support in msal-common #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jun 17, 2020
Merged

[msal-node][#1] SilentFlow support in msal-common #1711

merged 39 commits into from
Jun 17, 2020

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented May 27, 2020 •
edited
Loading

This PR adds support for SilentFlow in msal-common

This unblocks the below use cases for the end user:

  • Ability to call acquireTokenSilent from msal-browser and msal-node when the user has knowledge of the cached account
  • If the user chooses to forceRefresh or if the accessToken has expired, acquires a token with RefreshTokenFlow. This is achieved by calling the service with the cached refreshToken to acquire a new set of tokens.

@sameerag sameerag self-assigned this May 27, 2020
@github-actions github-actions bot added the msal-common Related to msal-common package label Jun 4, 2020
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-node Related to msal-node package labels Jun 4, 2020
@sameerag sameerag changed the base branch from msal-node-merge-request to dev June 4, 2020 21:34
@pkanher617 pkanher617 marked this pull request as ready for review June 11, 2020 00:52
@pkanher617 pkanher617 requested a review from DarylThayil as a code owner June 11, 2020 00:52
jasonnutter
jasonnutter suggested changes Jun 11, 2020
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 78.007% when pulling a156fcf on msal-node-cache-silentFlow into 504d352 on dev.

sangonzal
sangonzal approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some feedback from @jasonnutter looks relevant, chatted offline and agreed that it would be addressed in separate PR.

@pkanher617 pkanher617 merged commit 189cbe7 into dev Jun 17, 2020
@pkanher617 pkanher617 deleted the msal-node-cache-silentFlow branch June 17, 2020 23:15
This was referenced Jun 25, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@sangonzal sangonzal sangonzal approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees

@sameerag sameerag

Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sameerag @coveralls @jasonnutter @pkanher617 @sangonzal