[msal-common] Configuration and Client #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
changed the base branch from
authorization-code-flow-base
to
msal-node-scaffolding
sameerag
changed the title
…to msal-node-base
jmckennon
suggested changes
Mar 2, 2020
|
/lib/.DSStore should be ignored |
pkanher617
reviewed
Mar 2, 2020
pkanher617
reviewed
Mar 2, 2020
pkanher617
suggested changes
Mar 2, 2020
|
@DarylThayil The ignore rules for MSAL specific ignore filesnode_modules/ Doesn't this include |
|
A pattern for .DS_Store files should be added to the root gitignore (doesn't appear to be there), and the ds_store file in this commit should be deleted. |
|
Ah! I was looking at the wrong place! |
sangonzal
approved these changes
Mar 3, 2020
…ccount-authority-folders
…ders [msal-common] Create `account` and `authority` folders
pkanher617
suggested changes
Mar 13, 2020
pkanher617
approved these changes
Mar 17, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first for
msal-nodeand does the following:configandappmodulesThis will be followed up with a
PublicClientApplicationformsal-nodeandPublicClientSPAApplicationformsal-browserworking. Currently this branch is compilable only withmsal-common.