[msal-node] Cache-3: Add NodeStorage, token generation and separate SPAresponse #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l generation code
jasonnutter
suggested changes
Apr 20, 2020
sangonzal
suggested changes
Apr 21, 2020
lib/msal-common/src/unifiedCache/generator/TokenCacheGenerator.ts
Outdated
Show resolved
Hide resolved
lib/msal-common/src/unifiedCache/generator/TokenCacheGenerator.ts
Outdated
Show resolved
Hide resolved
lib/msal-common/src/unifiedCache/generator/TokenCacheGenerator.ts
Outdated
Show resolved
Hide resolved
pkanher617
reviewed
May 4, 2020
pkanher617
reviewed
May 4, 2020
pkanher617
reviewed
May 4, 2020
pkanher617
reviewed
May 4, 2020
pkanher617
approved these changes
May 4, 2020
[msal-node] Cache-5: Msal node cache additional changes for end-to-end cache to work
sangonzal
approved these changes
May 6, 2020
jasonnutter
approved these changes
May 8, 2020
[msal-node] Cache-4: ResponseHandler added to `msal-common`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is third in the series of cache PRs. Since I am breaking down a bigger PR into consumable chunks, this may not work end to end but does the following changes:
NodeStoragewith two new base APIs to read and write to external cacheNodeCacheManagercreated on request from AzureSDK which will soon morph intokeytarhook and eventually the extension libraryUnifiedCacheManager, currently does getAccounts and adds credentials to cache. This file will expand in future for cache lookups.TokenGeneratorto generate the token entities from response dataSPAResponseHandlerfor now ; this will fold to a single file inmsal-commonsoonTests:
Tests are coming, they are 80% there, need a few more