Skip to content

[msal-node]Cache-6: Read and write to disk, merge cache #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
May 20, 2020
Merged

[msal-node]Cache-6: Read and write to disk, merge cache #1622

merged 39 commits into from
May 20, 2020

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented May 10, 2020 •
edited
Loading

This PR has the following functionality added to the cache:

  • Reads and writes asynchronously from the disk
  • Introduces CacheContext which manages reading and writing into a cache file and merging the current cache with stored cacheBlob while doing so.

Todo:

Will have to make sure during file write/read, the accessed file is locked. This logic should be mostly in extension library, will update once we reach a consensus.

CacheSync

@sameerag sameerag marked this pull request as draft May 10, 2020 06:37
@sameerag sameerag changed the title [msal-node][msal-common] Cache 6: Read and write to disk, merge cache [msal-node][msal-common] Cache-6: Read and write to disk, merge cache May 10, 2020
@sameerag sameerag changed the title [msal-node][msal-common] Cache-6: Read and write to disk, merge cache [msal-node]Cache-6: Read and write to disk, merge cache May 10, 2020
@sameerag sameerag marked this pull request as ready for review May 11, 2020 13:38
@sameerag sameerag changed the base branch from msal-node-cache-entities to dev May 11, 2020 13:41
@sameerag sameerag changed the base branch from dev to msal-node-cache-entities May 11, 2020 13:42
sameerag and others added 13 commits May 11, 2020 06:43
pkanher617 and others added 13 commits May 11, 2020 15:33
@pkanher617
Merge branch 'dev' into fix-systemconfigbug
65c6df2
@pkanher617
fixing tests
9ac1e3c
Merge pull request #1631 from AzureAD/fix-systemconfigbug
2f9362f 
[msal-common][msal-browser] Fix issue where config was being overwritten by undefined values
@pkanher617
Merge branch 'dev' into common-beta-2-release
961cdf5
@pkanher617
Update changelog.md
de72adb
@pkanher617
Merge branch 'dev' into common-beta-2-release
a8b3191
Merge pull request #1632 from AzureAD/common-beta-2-release
217df59 
MSAL Common beta.2 release
@pkanher617
Merge branch 'dev' into browser-beta-2-release
eef0616
@pkanher617
Merge branch 'dev' into browser-beta-2-release
c472fff
Merge pull request #1633 from AzureAD/browser-beta-2-release
ba66362 
Release @azure/msal-browser v2.0.0-beta.2
@DarylThayil
clean up auth code sample a little
82382c8
@DarylThayil
Merge pull request #1641 from AzureAD/auth-sample-clean
1ee80e0 
clean up auth code sample a little
@DarylThayil
merge dev into branch
db845ff
@sameerag sameerag merged commit adae586 into msal-node-cache-entities May 20, 2020
This was referenced May 20, 2020
Closed
Closed
@sameerag sameerag deleted the msal-node-cache-fileops-async branch June 8, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanher617 pkanher617 pkanher617 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sameerag @pkanher617 @DarylThayil