Instance Discovery 2.x #1756

tnorling · 2020-06-05T18:07:52Z

Ports #1582 into msal-common
Similar to the previous PR for msal-core this PR does several things in regards to Authorities:

Removes the hardcoded trusted host list for AAD hosts and replaces it with a network call to discover hosts known to MS. This is done the first time resolveEndpointsAsync is called.
Combines B2C, AAD and ADFS authority classes into a single generic class
Introduces preferred_cache and preferred_network values used to determine which endpoint to hit and what authority to cache under. This is the only piece that differs from the msal-core implementation.

Developers can opt out of the network call in one of 2 ways:

Provide all trusted authorities they intend to use in knownAuthorities config option (B2C and ADFS only)
Provide instance metadata via instanceMetadata config option (AAD only)

TODO:

Add a few more unit tests
Doc Updates

Scheduled Refresh will be taken in future PR

…tion-library-for-js into msal-common-instance-discovery

coveralls · 2020-06-19T21:47:07Z

Coverage decreased (-0.3%) to 76.656% when pulling 4aead0a on msal-common-instance-discovery into 25d53da on dev.

…soft-authentication-library-for-js into msal-common-instance-discovery

.vscode/settings.json

pkanher617 · 2020-06-19T23:54:52Z

lib/msal-common/src/authority/TrustedAuthority.ts

+import { ClientConfigurationError } from "../error/ClientConfigurationError";
+
+export class TrustedAuthority {
+    private static InstanceMetadata: InstanceMetadataType = {};


Is there any reason to make these static? I would rather only make functions and fields static if needed.

Things like knownAuthorities and the network interface can then be passed into the constructor and re-used

I received feedback when I implemented knownAuthorities originally that it should be static. The idea is that it's a set once variable to prevent trying to switch up your knownAuthorities mid-stream so we don't want it to be tied to an instance where we may need to rebuild it.

lib/msal-common/src/config/ClientConfiguration.ts

pkanher617

Looks good except for a couple things that we could change. Would also like to see a sample but it can be done later.

tnorling · 2020-06-20T00:09:46Z

Looks good except for a couple things that we could change. Would also like to see a sample but it can be done later.

Sample showing knownAuthorities in PR #1775
Will create a sample for instanceMetadata next week

tnorling · 2020-06-22T19:44:01Z

lib/msal-browser/src/config/Configuration.ts

@@ -14,6 +14,7 @@ export type BrowserAuthOptions = {
    clientId: string;
    authority?: string;
    knownAuthorities?: Array<string>;
+    instanceMetadata?: Array<IInstanceDiscoveryMetadata>;


Naming here might get confusing when we implement the other perf changes which introduced authorityMetadata in msal-core. Open to suggestions for a better name here.

This reverts commit 4d35732.

This reverts commit 663e604.

This reverts commit da430bd.

This reverts commit 045acbe.

This reverts commit f939af1.

This reverts commit 27b0530.

This reverts commit ed17743.

This reverts commit 0dddb02.

…AD/microsoft-authentication-library-for-js into msal-common-instance-discovery" This reverts commit 4662361, reversing changes made to 4f15a91.

Port changes from msal-core

f3b6117

tnorling added the work-in-progress Issue or PR is not finished. label Jun 5, 2020

github-actions bot added the msal-common Related to msal-common package label Jun 5, 2020

tnorling added 7 commits June 18, 2020 12:54

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

7ae8baf

…tion-library-for-js into msal-common-instance-discovery

Add support for preferred_cache and preferred_network

6025e84

Update references to old temp constant

7872ca2

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

dcaff8e

…tion-library-for-js into msal-common-instance-discovery

Cleanup getInstanceMetadata

a71e396

Cleanup

b9d4e62

Update node and browser

9d10e65

github-actions bot added msal-browser Related to msal-browser package msal-node Related to msal-node package labels Jun 18, 2020

pkanher617 and others added 10 commits June 19, 2020 00:07

Adding code for instance_aware authentication in msal-browser

2600876

Adding graph hostname and graph host to the auth result

5307fa8

Adding AuthCodePayload object

710075d

Rename AuthCodeResponse file

d96595f

Update PublicClientApplication.ts

b2c6aa7

adding instance aware sample

53de8da

Remove policy from createAccount

171d4d0

Update environment for adfs

570b361

All common tests passing

55f7be5

Browser tests passing

4aead0a

tnorling added 2 commits June 19, 2020 15:54

Add tests

4f15a91

Merge branch 'instance-aware-2.0' of https://github.com/AzureAD/micro…

4662361

…soft-authentication-library-for-js into msal-common-instance-discovery

tnorling changed the base branch from dev to instance-aware-2.0 June 19, 2020 23:06

tnorling added 2 commits June 19, 2020 16:21

Add error

0dddb02

Update untrustedAuthority error message

ed17743

tnorling marked this pull request as ready for review June 19, 2020 23:42

tnorling requested a review from DarylThayil as a code owner June 19, 2020 23:42

tnorling requested review from jo-arroyo, pkanher617, sameerag and hectormmg as code owners June 19, 2020 23:42

tnorling removed the work-in-progress Issue or PR is not finished. label Jun 19, 2020

pkanher617 reviewed Jun 19, 2020

View reviewed changes

.vscode/settings.json Show resolved Hide resolved

pkanher617 reviewed Jun 19, 2020

View reviewed changes

lib/msal-common/src/config/ClientConfiguration.ts Show resolved Hide resolved

pkanher617 suggested changes Jun 20, 2020

View reviewed changes

tnorling added 4 commits June 19, 2020 17:10

Address feedback

27b0530

Address feedback

f939af1

Revert VScode settings

045acbe

Revert VScode settings

da430bd

tnorling commented Jun 22, 2020

View reviewed changes

tnorling added 11 commits June 22, 2020 13:05

Add performance doc

663e604

Add performance doc

4d35732

Revert "Add performance doc"

811121a

This reverts commit 4d35732.

Revert "Add performance doc"

d4686bd

This reverts commit 663e604.

Revert "Revert VScode settings"

5552d53

This reverts commit da430bd.

Revert "Revert VScode settings"

d678d50

This reverts commit 045acbe.

Revert "Address feedback"

30a8394

This reverts commit f939af1.

Revert "Address feedback"

c5a88a9

This reverts commit 27b0530.

Revert "Update untrustedAuthority error message"

842a292

This reverts commit ed17743.

Revert "Add error"

d89d5c6

This reverts commit 0dddb02.

Revert "Merge branch 'instance-aware-2.0' of https://github.com/Azure…

c326777

…AD/microsoft-authentication-library-for-js into msal-common-instance-discovery" This reverts commit 4662361, reversing changes made to 4f15a91.

tnorling changed the base branch from instance-aware-2.0 to logout-request June 22, 2020 20:57

tnorling closed this Jun 22, 2020

tnorling mentioned this pull request Jun 22, 2020

Instance Discovery 2.x #1811

Merged

tnorling deleted the msal-common-instance-discovery branch June 23, 2020 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Instance Discovery 2.x #1756

Instance Discovery 2.x #1756

Uh oh!

tnorling commented Jun 5, 2020 •

edited

Loading

Uh oh!

coveralls commented Jun 19, 2020

Uh oh!

Uh oh!

pkanher617 Jun 19, 2020

Uh oh!

pkanher617 Jun 19, 2020

Uh oh!

tnorling Jun 20, 2020

Uh oh!

Uh oh!

pkanher617 left a comment

Uh oh!

tnorling commented Jun 20, 2020

Uh oh!

tnorling Jun 22, 2020

Uh oh!

Uh oh!

Instance Discovery 2.x #1756

Instance Discovery 2.x #1756

Uh oh!

Conversation

tnorling commented Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 19, 2020

Uh oh!

Uh oh!

pkanher617 Jun 19, 2020

Choose a reason for hiding this comment

Uh oh!

pkanher617 Jun 19, 2020

Choose a reason for hiding this comment

Uh oh!

tnorling Jun 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkanher617 left a comment

Choose a reason for hiding this comment

Uh oh!

tnorling commented Jun 20, 2020

Uh oh!

tnorling Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tnorling commented Jun 5, 2020 •

edited

Loading