Instance Discovery 2.x #1811
Merged
Instance Discovery 2.x #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-library-for-js into msal-common-instance-discovery
…tion-library-for-js into msal-common-instance-discovery
github-actions
bot
added
msal-browser
…-authentication-library-for-js into msal-common-instance-discovery-update
tnorling
requested review from
DarylThayil,
jasonnutter and
jmckennon
as code owners
sameerag
reviewed
Jun 24, 2020
sameerag
reviewed
Jun 24, 2020
sameerag
approved these changes
Jun 24, 2020
jasonnutter
approved these changes
Jun 24, 2020
…tion-library-for-js into msal-common-instance-discovery-update
pkanher617
reviewed
Jun 25, 2020
pkanher617
reviewed
Jun 25, 2020
pkanher617
reviewed
Jun 25, 2020
lib/msal-common/src/authority/ICloudInstanceDiscoveryResponse.ts
Outdated
Show resolved
Hide resolved
pkanher617
reviewed
Jun 25, 2020
pkanher617
reviewed
Jun 25, 2020
pkanher617
reviewed
Jun 25, 2020
| import { ClientConfigurationError } from "../error/ClientConfigurationError"; | ||
|
|
||
| export class TrustedAuthority { | ||
| private static CloudDiscoveryMetadata: CloudDiscoveryMetadataType = {}; |
There was a problem hiding this comment.
do we need to make these static? can we make these all member functions of the prototype instead?
There was a problem hiding this comment.
Yes because we never instantiate TrustedAuthority this variable should only be set once
pkanher617
reviewed
Jun 25, 2020
pkanher617
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased from #1756. Ports #1582 into msal-common
Similar to the previous PR for msal-core this PR does several things in regards to Authorities:
preferred_cacheandpreferred_networkvalues used to determine which endpoint to hit and what authority to cache under. This is the only piece that differs from the msal-core implementation.Developers can opt out of the network call in one of 2 ways:
Scheduled Refresh will be taken in future PR