[msal-extensions] Extensions #2 #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sangonzal
commented
Jun 25, 2020
•
sangonzal
commented
- Add cross platform lock
- Add constant file
sangonzal
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
pkanher617,
sameerag,
hectormmg and
tnorling
as code owners
sangonzal
commented
Jun 25, 2020
| const processId = pid.toString(); | ||
| for (let tryCount = 0; tryCount < this.retryNumber; tryCount++) | ||
| try { | ||
| console.log("Pid " + pid + " trying to acquire lock"); |
There was a problem hiding this comment.
Every console.log statement will be switched over to using the msal-common logger in upcoming PR
pkanher617
reviewed
Jun 25, 2020
pkanher617
reviewed
Jun 25, 2020
|
Depending on the timeline, would like to see some form of unit testing. |
jasonnutter
approved these changes
Jun 30, 2020
github-actions
bot
added
the
samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.