Added Logger and RequestContextClasses #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rohitnarula7176, |
kpanwar
suggested changes
Apr 4, 2017
lib/AccessTokenKey.ts
Outdated
| @@ -2,14 +2,14 @@ namespace MSAL { | |||
| export class AccessTokenKey { | |||
| authority: string; | |||
| clientId: string; | |||
| user: User; | |||
| homeObjectId: string; | |||
There was a problem hiding this comment.
rename this to userIdentifier. this applies everywhere.
| this.nonce = Utils.Guid(); | ||
| } | ||
| this.correlationId = Utils.Guid(); | ||
| this.state = Utils.Guid(); |
There was a problem hiding this comment.
rename Utils.Guid to Utils.CreateNewGuid()
| str.push('scope=' + encodeURIComponent(this.parseScope(scopes))); | ||
| str.push('client_id=' + encodeURIComponent(this.clientId)); | ||
| str.push('redirect_uri=' + encodeURIComponent(this.redirectUri)); | ||
| str.push('state=' + encodeURIComponent(this.state)); | ||
| str.push('nonce=' + encodeURIComponent(this.nonce)); | ||
| if (this.extraQueryParameters) { | ||
| if (this.extraQueryParameters) |
There was a problem hiding this comment.
always use curly braces for readability and avoiding bugs. applies everywhere.
| static get error(): string { return "msal.error"; } | ||
| static get loginRequest(): string { return "msal.login.request"; } | ||
| static get loginError(): string { return "msal.login.error"; } | ||
| static get renewStatus(): string { return "msal.token.renew.status"; } |
lib/Logger.ts
Outdated
| VERBOSE | ||
|
|
||
| export interface ILoggerCallback { | ||
| (level: LogLevel, message: string,containsPii:boolean): boolean; |
| export class Logger {// Singleton Class | ||
| private static _instance: Logger; | ||
| private _correlationId: string; | ||
| get correlationId(): string { return this._correlationId; } |
There was a problem hiding this comment.
we should have set property on the correlationID.
lib/Logger.ts
Outdated
| set level(logLevel: LogLevel) { | ||
| if (LogLevel[logLevel]) | ||
| this._level = logLevel; | ||
| else throw new Error("Provide a valid value for level. Possibles range for logLevel is 0-3"); |
There was a problem hiding this comment.
this should be truly enum and not a number.
lib/RequestContext.ts
Outdated
| if (RequestContext._instance) { | ||
| return RequestContext._instance; | ||
| } | ||
| this._logger = new Logger(correlationId); |
|
|
||
| private _localCallback: ILoggerCallback; | ||
| get localCallback(): ILoggerCallback { return this._localCallback; } | ||
| set localCallback(localCallback: ILoggerCallback) { |
There was a problem hiding this comment.
set should fail is callback is already set.
shivbijlani
reviewed
Apr 4, 2017
lib/UserAgentApplication.ts
Outdated
| @@ -1,45 +1,63 @@ | |||
| ///<reference path='Storage.ts'/> | |||
|
|
|||
| interface Window { | |||
shivbijlani
reviewed
Apr 4, 2017
lib/UserAgentApplication.ts
Outdated
|
|
||
| namespace MSAL { | ||
|
|
||
| interface User { |
There was a problem hiding this comment.
Let this be in its own file.
rohitnarula7176
force-pushed
the
rohitn/loggerAPI
branch
from
ee36434 to
57cbc44
Compare
kpanwar
approved these changes
Apr 5, 2017
sangonzal
added a commit
that referenced
this pull request
Jun 30, 2020
[msal-extensions] Extensions #5
tnorling
added a commit
that referenced
this pull request
Sep 30, 2020
Broker #5: Move initialization out of the constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4