Add support for main thread OffscreenCanvas #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proposes support for
OffscreenCanvas
on the main thread.In general it seems like adding support for
OffscreenCanvas
is fairly trivial, the main requirement was to ensure that the correct constructor is referenced, and secondarily that no HTMLElement methods are used when dealing with anOffscreenCanvas
.I'm not very familiar with the code base overall, and I couldn't find tests, so it is difficult to tell if I patched everything correctly. But, I was able to record frames from an
OffscreenCanvas
in Chrome.Fixes #90