Skip to content

Add support for main thread OffscreenCanvas #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Conversation

cdata
Copy link
Contributor

@cdata cdata commented Dec 21, 2019

This change proposes support for OffscreenCanvas on the main thread.

In general it seems like adding support for OffscreenCanvas is fairly trivial, the main requirement was to ensure that the correct constructor is referenced, and secondarily that no HTMLElement methods are used when dealing with an OffscreenCanvas.

I'm not very familiar with the code base overall, and I couldn't find tests, so it is difficult to tell if I patched everything correctly. But, I was able to record frames from an OffscreenCanvas in Chrome.

Fixes #90

@cdata cdata mentioned this pull request Dec 21, 2019
@sebavan
Copy link
Member

sebavan commented Dec 21, 2019

This is already Christmas !!!

Thanks a lot, I do not have unit tests per se only test cases in the samples folder that I manually play, I ll just add one there for offscreen and publish again over the week end, thanks a lot for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OffscreenCanvas
2 participants