Latex #31
Open
Latex #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordering bug with deleted text in a list
Documents with sdt tags break content ordering
Conflicts: pydocx/parsers/Docx2Html.py pydocx/tests/test_docx.py pydocx/tests/test_xml.py
Stop using deprecated tags
| return r'\\' | ||
|
|
||
| def change_orientation(self, parsed, orient): | ||
| if orient == 'portrait': |
There was a problem hiding this comment.
This is not being called anywhere and there are no tests on it. We should remove it.
Not all docx files must have a styles.xml file
…e missing numbering.xml but still use lists.
Correctly handle files that don't have numbering.xml but also have lists
…ering the handler.
Underline val of 'none' still triggers the undreline handler
If BadZipFile is raised we should catch it and raise a different exception instead
| return '<br />' | ||
|
|
||
| def change_orientation(self, parsed, orient): |
There was a problem hiding this comment.
This is not being used anywhere, get rid of it.
|
How is the state of this? I am thinking about using the latex parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.