First PR - Implements the Opentracing API #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/datadoghq/trace/impl/Tracer.java
# Conflicts: # src/main/java/com/datadoghq/trace/impl/DDSpan.java
added 16 commits
May 2, 2017 12:05
…d do not instantiate HashMap if it's not needed)
LotharSee
reviewed
May 3, 2017
| * | ||
| * @return true if root, false otherwise | ||
| */ | ||
| private boolean isRootSpan() { |
There was a problem hiding this comment.
Two things:
-
We use the convention
spanID == 0to define the root. Was OT requiringTraceID == SpanIDinstead? -
That won't work with distributed traces, where the "global root" can be from another host. In that case, you will have a "local root" instrumented here, but which won't follow this convention.
So we should do it differently (either not relying onisRootSpanfor the flush, or putting a "root" marker on the first span created).
LotharSee
reviewed
May 3, 2017
| * | ||
| * @param sampleRate a number [0,1] representing the rate ratio. | ||
| */ | ||
| public RateSampler(double sampleRate) { |
There was a problem hiding this comment.
For the statistic and sampling mechanisms below (Agent, backend) to work well, we have to put the applied sampleRate in the meta _sample_rate.
There was a problem hiding this comment.
(let me fix this one, I need to work on my Java).
richardstartin
added a commit
that referenced
this pull request
Oct 19, 2020
# This is the 1st commit message: make excludefilterprovider interface easier to work with # The commit message #2 will be skipped: # fixup
tylerbenson
added a commit
that referenced
this pull request
Dec 3, 2020
Currently fails with the following exception:
```
Bad access to protected data in invokevirtual
Exception Details:
Location:
io/netty/util/concurrent/GlobalEventExecutor.execute(Ljava/lang/Runnable;)V @76: invokevirtual
Reason:
Type 'java/util/concurrent/AbstractExecutorService' (current frame, stack[0]) is not assignable to 'io/netty/util/concurrent/GlobalEventExecutor'
Current Frame:
bci: @76
flags: { }
locals: { 'io/netty/util/concurrent/GlobalEventExecutor', 'java/lang/Runnable' }
stack: { 'java/util/concurrent/AbstractExecutorService', 'java/lang/Runnable', null }
Bytecode:
0x0000000: 2bc1 0111 9a00 2201 2ba5 001d b201 172b
0x0000010: b801 1d9a 0013 2bb6 0048 b601 2313 0125
0x0000020: b601 2b99 0006 a700 3a2b c101 2d99 0012
0x0000030: bb01 2f59 2bb8 0133 b701 354c a700 212a
0x0000040: c101 3799 0010 2ac0 0137 2b01 b601 3b4c
0x0000050: a700 0dbb 013d 592b 01b7 0140 4ca7 0003
0x0000060: 2a4d 2b4e 2dc7 000d bb00 a859 12a9 b700
0x0000070: acbf 2c2d b700 d62c b600 d89a 0007 2cb7
0x0000080: 00db a700 0301 4da7 0004 4d01 2ca5 0015
0x0000090: 2bc1 0111 9900 0e2b c001 1104 b901 4402
0x00000a0: 0057 a700 032c c600 052c bfb1
Exception Handler Table:
bci [100, 133] => handler: 138
Stackmap Table:
same_frame(@38)
same_frame(@41)
same_frame(@63)
same_frame(@83)
same_frame(@93)
same_frame(@96)
append_frame(@100,Object[#2],Object[#126])
same_frame(@114)
same_frame(@130)
full_frame(@133,{Object[#2],Object[#126]},{})
same_locals_1_stack_item_frame(@138,Object[#271])
append_frame(@139,Object[#271])
same_frame(@162)
same_frame(@165)
same_frame(@171)
```
randomanderson
added a commit
that referenced
this pull request
Mar 26, 2021
^ This is the 1st commit message: use env file to push version ^ The commit message #2 will be skipped: ^ upstream.env is in the current folder?
bantonsson
pushed a commit
that referenced
this pull request
Dec 6, 2021
Enable compilation with Java 11 for Jetty 11 instrumentation
DDJavierSantos
added a commit
that referenced
this pull request
Mar 6, 2023
# This is the 1st commit message: Resteasy IAST instrumentation # This is the commit message #2: Addressing git comments
DDJavierSantos
added a commit
that referenced
this pull request
Jun 23, 2023
# This is the 1st commit message: started Ready for test checks spotless fixing tests Some more tests fixed spotless Some more fixes spotless Quota test added cleanup small optimization in HttpResponseHeaderModuleImpl optimization test fixes spotless # This is the commit message #2: fix a import missing from master rebase
DDJavierSantos
added a commit
that referenced
this pull request
Aug 9, 2023
# This is the 1st commit message: Removing statements that log sensitive information and exceptions since they would be sent over the wire by the telemetry logging API Changing statements so they use placeholders instead of adding strings # This is the commit message #2: linter applied Update dd-smoke-tests/jboss-modules/src/main/java/datadog/smoketest/jbossmodules/common/ServiceSupport.java Co-authored-by: Santiago M. Mola <[email protected]> processing PR comments Processing PR comments This statement doesn't need the placeholder
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce a new Tracer for the Java Instrumentation. Implementing the opentracing API
Who will it impact?
Raclette-team
Motivation
Propose a solution for instrumenting Java code
Testing Guidelines
Additional Notes