First PR - Implements the Opentracing API #2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,156 +1,34 @@ | ||
| # Maven # | ||
| ######### | ||
| target | ||
|
|
||
| # Eclipse # | ||
| ########### | ||
| *.launch | ||
| .settings | ||
| .project | ||
| .classpath | ||
|
|
||
| # OS generated files # | ||
| ###################### | ||
| .DS_Store | ||
| .DS_Store? | ||
| ._* | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| Icon? | ||
| ehthumbs.db | ||
| Thumbs.db | ||
|
|
||
| # Intellij Idea # | ||
| ################# | ||
| /.idea | ||
| *.iml | ||
|
|
||
| # Visual Studio Code # | ||
| ###################### | ||
| .vscode | ||
|
|
||
| # Others # | ||
| ########## | ||
| /logs/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>com.datadog</groupId> | ||
| <artifactId>raclette-java</artifactId> | ||
| <version>1.0-SNAPSHOT</version> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.opentracing</groupId> | ||
| <artifactId>opentracing-api</artifactId> | ||
| <version>0.21.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.8.8</version> | ||
| </dependency> | ||
|
|
||
| <!-- Logging dependencies --> | ||
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>1.7.25</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.2.3</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>net.logstash.logback</groupId> | ||
| <artifactId>logstash-logback-encoder</artifactId> | ||
| <version>4.9</version> | ||
| </dependency> | ||
|
|
||
| <!-- Testing dependencies --> | ||
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.12</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> | ||
| <version>3.6.2</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <version>2.7.22</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>1.6</source> | ||
| <target>1.6</target> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.datadoghq.trace; | ||
|
|
||
|
|
||
| import io.opentracing.Span; | ||
|
|
||
| /** | ||
| * Main interface to sample a collection of traces. | ||
| */ | ||
| public interface Sampler { | ||
|
|
||
| /** | ||
| * Sample a collection of traces based on the parent span | ||
| * | ||
| * @param span the parent span with its context | ||
| * @return true when the trace/spans has to be reported/written | ||
| */ | ||
| boolean sample(Span span); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package com.datadoghq.trace; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import io.opentracing.Span; | ||
|
|
||
| /** | ||
| * A writer is responsible to send collected spans to some place | ||
| */ | ||
| public interface Writer { | ||
|
|
||
| /** | ||
| * Write a trace represented by the entire list of all the finished spans | ||
| * | ||
| * @param trace the list of spans to write | ||
| */ | ||
| void write(List<Span> trace); | ||
|
There was a problem hiding this comment. Is order important? If not, this should probably be a There was a problem hiding this comment. No unfortunately we send List<List> (or list of traces if you prefer) to the writer There was a problem hiding this comment. @renaudboutet not sure that the order is so important. We just have to send an array of span. A collection should be fine |
||
|
|
||
| /** | ||
| * Indicates to the writer that no future writing will come and it should terminates all connections and tasks | ||
| */ | ||
| void close(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.datadoghq.trace.impl; | ||
|
|
||
| import com.datadoghq.trace.Sampler; | ||
| import io.opentracing.Span; | ||
|
|
||
| /** | ||
| * Sampler that always says yes... | ||
| */ | ||
| public class AllSampler implements Sampler { | ||
|
|
||
| @Override | ||
| public boolean sample(Span span) { | ||
| return true; | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably in test scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed