more executor tests #2002
Merged
more executor tests #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
added
comp: testing
richardstartin
commented
Oct 19, 2020
| @@ -45,9 +45,6 @@ public AbstractExecutorInstrumentation(final String... additionalNames) { | |||
| PERMITTED_EXECUTORS_PREFIXES = Collections.emptyList(); | |||
| } else { | |||
| final String[] whitelist = { | |||
There was a problem hiding this comment.
The executors here all just wrap other executors
bantonsson
reviewed
Oct 19, 2020
dd-java-agent/instrumentation/java-concurrent/src/test/groovy/RejectedExecutionTest.groovy
Show resolved
Hide resolved
richardstartin
force-pushed
the
rgs/more-executor-tests
branch
from
86828bb to
219b5e7
Compare
tylerbenson
approved these changes
Oct 19, 2020
mcculls
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generalises the rejected execution handler instrumentation to support the netty flavour of the abstraction, disallows some delegating/wrapping executors (but keeps/adds tests for them) because they lead to doubling the work done, and if they e.g. capture the continuation, but catch a
RejectedExecutionExceptionthen we may miss the chance to cancel the continuation.