Skip to content

Consistency: instrumentation classes should be in files ending with Instrumentation.java #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

Consistency: instrumentation classes should be in files ending with Instrumentation.java #8144

merged 1 commit into from
Jan 3, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 2, 2025 •
edited by jira bot
Loading

Motivation

This is so we can direct load requests to a special class-loader that can be unloaded after use.

Additional Notes

See https://github.com/DataDog/dd-trace-java/blob/master/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/DatadogClassLoader.java#L97

Contributor Checklist

Jira ticket: LANGPLAT-117

@mcculls
Consistency: instrumentation classes should be in files ending with I…
330a358 
…nstrumentation.java

This is so we can direct load requests to a special class-loader that can be unloaded after use.
@mcculls mcculls added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring labels Jan 2, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 2, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/consistent-instrumentation-naming
git_commit_date 1735830355 1735855786
git_commit_sha 1951e6f 330a358
release_version 1.45.0-SNAPSHOT~1951e6f72e 1.45.0-SNAPSHOT~330a358197
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735858320 1735858320
ci_job_id 753246545 753246545
ci_pipeline_id 52059178 52059178
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064673
Total [baseline] (10.517 s) : 0, 10517051
Agent [candidate] (1.054 s) : 0, 1054111
Total [candidate] (10.425 s) : 0, 10425262
section appsec
Agent [baseline] (1.193 s) : 0, 1193213
Total [baseline] (10.732 s) : 0, 10731955
Agent [candidate] (1.188 s) : 0, 1188387
Total [candidate] (10.789 s) : 0, 10789343
section iast
Agent [baseline] (1.181 s) : 0, 1180547
Total [baseline] (10.984 s) : 0, 10983524
Agent [candidate] (1.18 s) : 0, 1179618
Total [candidate] (10.977 s) : 0, 10977281
section profiling
Agent [baseline] (1.277 s) : 0, 1276744
Total [baseline] (10.883 s) : 0, 10883380
Agent [candidate] (1.276 s) : 0, 1275625
Total [candidate] (10.825 s) : 0, 10825226
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.193 s 128.54 ms (12.1%)
Agent iast 1.181 s 115.874 ms (10.9%)
Agent profiling 1.277 s 212.071 ms (19.9%)
Total tracing 10.517 s -
Total appsec 10.732 s 214.904 ms (2.0%)
Total iast 10.984 s 466.474 ms (4.4%)
Total profiling 10.883 s 366.329 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.188 s 134.276 ms (12.7%)
Agent iast 1.18 s 125.507 ms (11.9%)
Agent profiling 1.276 s 221.514 ms (21.0%)
Total tracing 10.425 s -
Total appsec 10.789 s 364.081 ms (3.5%)
Total iast 10.977 s 552.02 ms (5.3%)
Total profiling 10.825 s 399.965 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.508 ms) : 0, 720508
BytebuddyAgent [candidate] (713.722 ms) : 0, 713722
GlobalTracer [baseline] (260.135 ms) : 0, 260135
GlobalTracer [candidate] (257.165 ms) : 0, 257165
AppSec [baseline] (55.876 ms) : 0, 55876
AppSec [candidate] (55.369 ms) : 0, 55369
Remote Config [baseline] (734.859 µs) : 0, 735
Remote Config [candidate] (729.888 µs) : 0, 730
Telemetry [baseline] (12.153 ms) : 0, 12153
Telemetry [candidate] (12.052 ms) : 0, 12052
section appsec
BytebuddyAgent [baseline] (733.506 ms) : 0, 733506
BytebuddyAgent [candidate] (730.224 ms) : 0, 730224
GlobalTracer [baseline] (254.67 ms) : 0, 254670
GlobalTracer [candidate] (253.552 ms) : 0, 253552
AppSec [baseline] (170.316 ms) : 0, 170316
AppSec [candidate] (170.776 ms) : 0, 170776
Remote Config [baseline] (674.307 µs) : 0, 674
Remote Config [candidate] (670.596 µs) : 0, 671
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (8.417 ms) : 0, 8417
IAST [baseline] (20.321 ms) : 0, 20321
IAST [candidate] (19.391 ms) : 0, 19391
section iast
BytebuddyAgent [baseline] (830.033 ms) : 0, 830033
BytebuddyAgent [candidate] (829.47 ms) : 0, 829470
GlobalTracer [baseline] (246.796 ms) : 0, 246796
GlobalTracer [candidate] (246.592 ms) : 0, 246592
AppSec [baseline] (58.098 ms) : 0, 58098
AppSec [candidate] (57.924 ms) : 0, 57924
Remote Config [baseline] (649.795 µs) : 0, 650
Remote Config [candidate] (643.663 µs) : 0, 644
Telemetry [baseline] (8.496 ms) : 0, 8496
Telemetry [candidate] (8.522 ms) : 0, 8522
IAST [baseline] (21.462 ms) : 0, 21462
IAST [candidate] (21.365 ms) : 0, 21365
section profiling
BytebuddyAgent [baseline] (702.792 ms) : 0, 702792
BytebuddyAgent [candidate] (703.057 ms) : 0, 703057
GlobalTracer [baseline] (372.345 ms) : 0, 372345
GlobalTracer [candidate] (372.771 ms) : 0, 372771
AppSec [baseline] (54.844 ms) : 0, 54844
AppSec [candidate] (54.095 ms) : 0, 54095
Remote Config [baseline] (668.362 µs) : 0, 668
Remote Config [candidate] (666.017 µs) : 0, 666
Telemetry [baseline] (7.883 ms) : 0, 7883
Telemetry [candidate] (7.843 ms) : 0, 7843
ProfilingAgent [baseline] (96.381 ms) : 0, 96381
ProfilingAgent [candidate] (95.259 ms) : 0, 95259
Profiling [baseline] (96.41 ms) : 0, 96410
Profiling [candidate] (95.286 ms) : 0, 95286
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056270
Total [baseline] (8.609 s) : 0, 8609056
Agent [candidate] (1.054 s) : 0, 1053586
Total [candidate] (8.622 s) : 0, 8622093
section iast
Agent [baseline] (1.18 s) : 0, 1180486
Total [baseline] (9.188 s) : 0, 9188253
Agent [candidate] (1.181 s) : 0, 1180986
Total [candidate] (9.213 s) : 0, 9213097
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1189254
Total [baseline] (9.252 s) : 0, 9252063
Agent [candidate] (1.181 s) : 0, 1180595
Total [candidate] (9.193 s) : 0, 9193302
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180498
Total [baseline] (9.189 s) : 0, 9188574
Agent [candidate] (1.184 s) : 0, 1184371
Total [candidate] (9.215 s) : 0, 9214679
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.18 s 124.216 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.189 s 132.984 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.18 s 124.228 ms (11.8%)
Total tracing 8.609 s -
Total iast 9.188 s 579.197 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.252 s 643.006 ms (7.5%)
Total iast_TELEMETRY_OFF 9.189 s 579.517 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.181 s 127.4 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 127.008 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.184 s 130.785 ms (12.4%)
Total tracing 8.622 s -
Total iast 9.213 s 591.004 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.193 s 571.209 ms (6.6%)
Total iast_TELEMETRY_OFF 9.215 s 592.586 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.81 ms) : 0, 713810
BytebuddyAgent [candidate] (713.204 ms) : 0, 713204
GlobalTracer [baseline] (258.436 ms) : 0, 258436
GlobalTracer [candidate] (256.791 ms) : 0, 256791
AppSec [baseline] (55.493 ms) : 0, 55493
AppSec [candidate] (55.214 ms) : 0, 55214
Remote Config [baseline] (723.711 µs) : 0, 724
Remote Config [candidate] (732.433 µs) : 0, 732
Telemetry [baseline] (12.761 ms) : 0, 12761
Telemetry [candidate] (12.592 ms) : 0, 12592
section iast
BytebuddyAgent [baseline] (829.752 ms) : 0, 829752
BytebuddyAgent [candidate] (830.113 ms) : 0, 830113
GlobalTracer [baseline] (246.768 ms) : 0, 246768
GlobalTracer [candidate] (247.067 ms) : 0, 247067
AppSec [baseline] (58.169 ms) : 0, 58169
AppSec [candidate] (58.171 ms) : 0, 58171
IAST [baseline] (21.523 ms) : 0, 21523
IAST [candidate] (21.423 ms) : 0, 21423
Remote Config [baseline] (669.486 µs) : 0, 669
Remote Config [candidate] (653.35 µs) : 0, 653
Telemetry [baseline] (8.547 ms) : 0, 8547
Telemetry [candidate] (8.548 ms) : 0, 8548
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.727 ms) : 0, 835727
BytebuddyAgent [candidate] (829.426 ms) : 0, 829426
GlobalTracer [baseline] (248.474 ms) : 0, 248474
GlobalTracer [candidate] (246.65 ms) : 0, 246650
AppSec [baseline] (58.768 ms) : 0, 58768
AppSec [candidate] (58.469 ms) : 0, 58469
IAST [baseline] (21.878 ms) : 0, 21878
IAST [candidate] (21.673 ms) : 0, 21673
Remote Config [baseline] (667.466 µs) : 0, 667
Remote Config [candidate] (665.743 µs) : 0, 666
Telemetry [baseline] (8.752 ms) : 0, 8752
Telemetry [candidate] (8.726 ms) : 0, 8726
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.981 ms) : 0, 828981
BytebuddyAgent [candidate] (832.554 ms) : 0, 832554
GlobalTracer [baseline] (248.334 ms) : 0, 248334
GlobalTracer [candidate] (248.424 ms) : 0, 248424
AppSec [baseline] (57.9 ms) : 0, 57900
AppSec [candidate] (58.058 ms) : 0, 58058
IAST [baseline] (21.052 ms) : 0, 21052
IAST [candidate] (21.05 ms) : 0, 21050
Remote Config [baseline] (652.785 µs) : 0, 653
Remote Config [candidate] (661.675 µs) : 0, 662
Telemetry [baseline] (8.483 ms) : 0, 8483
Telemetry [candidate] (8.53 ms) : 0, 8530
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-02T22:22:18 2025-01-02T22:29:18
git_branch master mcculls/consistent-instrumentation-naming
git_commit_date 1735830355 1735855786
git_commit_sha 1951e6f 330a358
release_version 1.45.0-SNAPSHOT~1951e6f72e 1.45.0-SNAPSHOT~330a358197
start_time 2025-01-02T22:22:04 2025-01-02T22:29:04
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735857314 1735857314
ci_job_id 753246547 753246547
ci_pipeline_id 52059178 52059178
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.707 µs) : 359, 399
.   : milestone, 379,
iast (500.791 µs) : 479, 522
.   : milestone, 501,
iast_FULL (664.104 µs) : 642, 686
.   : milestone, 664,
iast_GLOBAL (537.986 µs) : 515, 561
.   : milestone, 538,
iast_HARDCODED_SECRET_DISABLED (497.637 µs) : 476, 519
.   : milestone, 498,
iast_INACTIVE (461.917 µs) : 441, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (491.222 µs) : 469, 513
.   : milestone, 491,
tracing (454.494 µs) : 434, 475
.   : milestone, 454,
section candidate
no_agent (381.753 µs) : 361, 403
.   : milestone, 382,
iast (504.961 µs) : 483, 527
.   : milestone, 505,
iast_FULL (660.204 µs) : 638, 682
.   : milestone, 660,
iast_GLOBAL (529.518 µs) : 508, 551
.   : milestone, 530,
iast_HARDCODED_SECRET_DISABLED (506.717 µs) : 485, 528
.   : milestone, 507,
iast_INACTIVE (461.075 µs) : 441, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (493.23 µs) : 472, 515
.   : milestone, 493,
tracing (453.085 µs) : 432, 474
.   : milestone, 453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.707 µs [358.641 µs, 398.772 µs] -
iast 500.791 µs [479.257 µs, 522.325 µs] 122.084 µs (32.2%)
iast_FULL 664.104 µs [642.416 µs, 685.793 µs] 285.398 µs (75.4%)
iast_GLOBAL 537.986 µs [514.671 µs, 561.301 µs] 159.279 µs (42.1%)
iast_HARDCODED_SECRET_DISABLED 497.637 µs [476.328 µs, 518.946 µs] 118.93 µs (31.4%)
iast_INACTIVE 461.917 µs [440.767 µs, 483.066 µs] 83.21 µs (22.0%)
iast_TELEMETRY_OFF 491.222 µs [469.269 µs, 513.175 µs] 112.515 µs (29.7%)
tracing 454.494 µs [433.992 µs, 474.996 µs] 75.787 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.753 µs [360.856 µs, 402.65 µs] -
iast 504.961 µs [482.896 µs, 527.025 µs] 123.207 µs (32.3%)
iast_FULL 660.204 µs [638.469 µs, 681.939 µs] 278.451 µs (72.9%)
iast_GLOBAL 529.518 µs [508.097 µs, 550.939 µs] 147.765 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 506.717 µs [484.94 µs, 528.495 µs] 124.964 µs (32.7%)
iast_INACTIVE 461.075 µs [440.513 µs, 481.638 µs] 79.322 µs (20.8%)
iast_TELEMETRY_OFF 493.23 µs [471.802 µs, 514.659 µs] 111.477 µs (29.2%)
tracing 453.085 µs [432.31 µs, 473.86 µs] 71.332 µs (18.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.373 ms) : 1353, 1394
.   : milestone, 1373,
appsec (1.773 ms) : 1749, 1797
.   : milestone, 1773,
appsec_no_iast (1.763 ms) : 1740, 1786
.   : milestone, 1763,
iast (1.51 ms) : 1487, 1533
.   : milestone, 1510,
profiling (1.503 ms) : 1479, 1526
.   : milestone, 1503,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
section candidate
no_agent (1.37 ms) : 1351, 1390
.   : milestone, 1370,
appsec (1.756 ms) : 1732, 1780
.   : milestone, 1756,
appsec_no_iast (1.786 ms) : 1761, 1811
.   : milestone, 1786,
iast (1.507 ms) : 1484, 1530
.   : milestone, 1507,
profiling (1.557 ms) : 1533, 1582
.   : milestone, 1557,
tracing (1.513 ms) : 1489, 1537
.   : milestone, 1513,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.373 ms [1.353 ms, 1.394 ms] -
appsec 1.773 ms [1.749 ms, 1.797 ms] 399.328 µs (29.1%)
appsec_no_iast 1.763 ms [1.74 ms, 1.786 ms] 389.744 µs (28.4%)
iast 1.51 ms [1.487 ms, 1.533 ms] 136.939 µs (10.0%)
profiling 1.503 ms [1.479 ms, 1.526 ms] 129.203 µs (9.4%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 99.47 µs (7.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.351 ms, 1.39 ms] -
appsec 1.756 ms [1.732 ms, 1.78 ms] 385.576 µs (28.1%)
appsec_no_iast 1.786 ms [1.761 ms, 1.811 ms] 415.821 µs (30.3%)
iast 1.507 ms [1.484 ms, 1.53 ms] 136.795 µs (10.0%)
profiling 1.557 ms [1.533 ms, 1.582 ms] 187.344 µs (13.7%)
tracing 1.513 ms [1.489 ms, 1.537 ms] 143.122 µs (10.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/consistent-instrumentation-naming
git_commit_date 1735830355 1735855786
git_commit_sha 1951e6f 330a358
release_version 1.45.0-SNAPSHOT~1951e6f72e 1.45.0-SNAPSHOT~330a358197
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1735857879 1735857879
ci_job_id 753246550 753246550
ci_pipeline_id 52059178 52059178
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
appsec (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
iast (18.9 s) : 18900000, 18900000
.   : milestone, 18900000,
iast_GLOBAL (18.04 s) : 18040000, 18040000
.   : milestone, 18040000,
profiling (15.338 s) : 15338000, 15338000
.   : milestone, 15338000,
tracing (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
section candidate
no_agent (14.881 s) : 14881000, 14881000
.   : milestone, 14881000,
appsec (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
iast (18.767 s) : 18767000, 18767000
.   : milestone, 18767000,
iast_GLOBAL (17.863 s) : 17863000, 17863000
.   : milestone, 17863000,
profiling (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.957 s [14.957 s, 14.957 s] -
appsec 15.145 s [15.145 s, 15.145 s] 188.0 ms (1.3%)
iast 18.9 s [18.9 s, 18.9 s] 3.943 s (26.4%)
iast_GLOBAL 18.04 s [18.04 s, 18.04 s] 3.083 s (20.6%)
profiling 15.338 s [15.338 s, 15.338 s] 381.0 ms (2.5%)
tracing 15.183 s [15.183 s, 15.183 s] 226.0 ms (1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.881 s [14.881 s, 14.881 s] -
appsec 15.027 s [15.027 s, 15.027 s] 146.0 ms (1.0%)
iast 18.767 s [18.767 s, 18.767 s] 3.886 s (26.1%)
iast_GLOBAL 17.863 s [17.863 s, 17.863 s] 2.982 s (20.0%)
profiling 14.948 s [14.948 s, 14.948 s] 67.0 ms (0.5%)
tracing 15.114 s [15.114 s, 15.114 s] 233.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~330a358197, baseline=1.45.0-SNAPSHOT~1951e6f72e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.355 ms) : 2312, 2397
.   : milestone, 2355,
iast (2.088 ms) : 2034, 2141
.   : milestone, 2088,
iast_GLOBAL (2.144 ms) : 2089, 2198
.   : milestone, 2144,
profiling (1.952 ms) : 1909, 1995
.   : milestone, 1952,
tracing (1.941 ms) : 1899, 1982
.   : milestone, 1941,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.355 ms) : 2312, 2397
.   : milestone, 2355,
iast (2.092 ms) : 2038, 2145
.   : milestone, 2092,
iast_GLOBAL (2.136 ms) : 2082, 2190
.   : milestone, 2136,
profiling (1.979 ms) : 1935, 2023
.   : milestone, 1979,
tracing (1.94 ms) : 1898, 1981
.   : milestone, 1940,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.355 ms [2.312 ms, 2.397 ms] 887.673 µs (60.5%)
iast 2.088 ms [2.034 ms, 2.141 ms] 620.678 µs (42.3%)
iast_GLOBAL 2.144 ms [2.089 ms, 2.198 ms] 676.675 µs (46.1%)
profiling 1.952 ms [1.909 ms, 1.995 ms] 484.971 µs (33.1%)
tracing 1.941 ms [1.899 ms, 1.982 ms] 473.812 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.355 ms [2.312 ms, 2.397 ms] 886.412 µs (60.4%)
iast 2.092 ms [2.038 ms, 2.145 ms] 623.529 µs (42.5%)
iast_GLOBAL 2.136 ms [2.082 ms, 2.19 ms] 667.863 µs (45.5%)
profiling 1.979 ms [1.935 ms, 2.023 ms] 511.058 µs (34.8%)
tracing 1.94 ms [1.898 ms, 1.981 ms] 471.334 µs (32.1%)

PerfectSlayer
PerfectSlayer approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing them!

@PerfectSlayer
Copy link
Contributor

I restarted muzzle tasks and linked to the LANGPLAT-117 card if you don't have another one to add.

@mcculls mcculls marked this pull request as ready for review January 3, 2025 09:46
@mcculls mcculls requested a review from a team as a code owner January 3, 2025 09:46
@mcculls mcculls requested review from smola and Mariovido January 3, 2025 09:46
@mcculls mcculls merged commit a8b33d5 into master Jan 3, 2025
155 checks passed
@mcculls mcculls deleted the mcculls/consistent-instrumentation-naming branch January 3, 2025 09:47
@github-actions github-actions bot added this to the 1.45.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer