Skip to content

Consistency: instrumentation classes should be in files ending with Instrumentation.java #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Consistency: instrumentation classes should be in files ending with Instrumentation.java #8144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...upload/CommonsFileuploadInstrumenter.java → ...oad/CommonsFileuploadInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
import net.bytebuddy.asm.Advice;

@AutoService(InstrumenterModule.class)
public class CommonsFileuploadInstrumenter extends InstrumenterModule.Iast
public class CommonsFileuploadInstrumentation extends InstrumenterModule.Iast
implements Instrumenter.ForKnownTypes, Instrumenter.HasMethodAdvice {

public CommonsFileuploadInstrumenter() {
public CommonsFileuploadInstrumentation() {
super("commons-fileupload");
}

Expand Down
4 changes: 2 additions & 2 deletions ...mons/fileupload/FileItemInstrumenter.java → ...s/fileupload/FileItemInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
import org.apache.commons.fileupload.FileItem;

@AutoService(InstrumenterModule.class)
public class FileItemInstrumenter extends InstrumenterModule.Iast
public class FileItemInstrumentation extends InstrumenterModule.Iast
implements Instrumenter.ForTypeHierarchy, Instrumenter.HasMethodAdvice {

public FileItemInstrumenter() {
public FileItemInstrumentation() {
super("commons-fileupload", "fileitem");
}

Expand Down
4 changes: 2 additions & 2 deletions ...eupload/FileItemIteratorInstrumenter.java → ...load/FileItemIteratorInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
import org.apache.commons.fileupload.FileItemStream;

@AutoService(InstrumenterModule.class)
public class FileItemIteratorInstrumenter extends InstrumenterModule.Iast
public class FileItemIteratorInstrumentation extends InstrumenterModule.Iast
implements Instrumenter.ForTypeHierarchy, Instrumenter.HasMethodAdvice {

public FileItemIteratorInstrumenter() {
public FileItemIteratorInstrumentation() {
super("commons-fileupload", "fileitemiterator");
}

Expand Down
4 changes: 2 additions & 2 deletions ...ileupload/FileItemStreamInstrumenter.java → ...upload/FileItemStreamInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
import org.apache.commons.fileupload.FileItemStream;

@AutoService(InstrumenterModule.class)
public class FileItemStreamInstrumenter extends InstrumenterModule.Iast
public class FileItemStreamInstrumentation extends InstrumenterModule.Iast
implements Instrumenter.ForTypeHierarchy, Instrumenter.HasMethodAdvice {

public FileItemStreamInstrumenter() {
public FileItemStreamInstrumentation() {
super("commons-fileupload", "fileitemstream");
}

Expand Down
4 changes: 2 additions & 2 deletions ...upload/ServletFileUploadInstrumenter.java → ...oad/ServletFileUploadInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
import org.apache.commons.fileupload.FileItemIterator;

@AutoService(InstrumenterModule.class)
public class ServletFileUploadInstrumenter extends InstrumenterModule.Iast
public class ServletFileUploadInstrumentation extends InstrumenterModule.Iast
implements Instrumenter.ForSingleType, Instrumenter.HasMethodAdvice {

public ServletFileUploadInstrumenter() {
public ServletFileUploadInstrumentation() {
super("commons-fileupload", "servlet");
}

Expand Down
2 changes: 1 addition & 1 deletion ...st/groovy/FileItemInstrumenterTest.groovy → ...groovy/FileItemInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import datadog.trace.bootstrap.instrumentation.api.AgentTracer
import datadog.trace.bootstrap.instrumentation.api.TagContext
import foo.bar.smoketest.MockFileItem

class FileItemInstrumenterTest extends AgentTestRunner {
class FileItemInstrumentationTest extends AgentTestRunner {

private Object iastCtx

Expand Down
2 changes: 1 addition & 1 deletion ...y/FileItemIteratorInstrumenterTest.groovy → ...ileItemIteratorInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import datadog.trace.bootstrap.instrumentation.api.TagContext
import foo.bar.smoketest.MockFileItemIterator
import foo.bar.smoketest.MockFileItemStream

class FileItemIteratorInstrumenterTest extends AgentTestRunner {
class FileItemIteratorInstrumentationTest extends AgentTestRunner {

private Object iastCtx

Expand Down
2 changes: 1 addition & 1 deletion ...ovy/FileItemStreamInstrumenterTest.groovy → .../FileItemStreamInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import datadog.trace.bootstrap.instrumentation.api.AgentTracer
import datadog.trace.bootstrap.instrumentation.api.TagContext
import foo.bar.smoketest.MockFileItemStream

class FileItemStreamInstrumenterTest extends AgentTestRunner {
class FileItemStreamInstrumentationTest extends AgentTestRunner {

private Object iastCtx

Expand Down
2 changes: 1 addition & 1 deletion .../ServletFileUploadInstrumenterTest.groovy → ...rvletFileUploadInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import org.apache.commons.fileupload.FileItemIterator
import org.apache.commons.fileupload.disk.DiskFileItemFactory
import org.apache.commons.fileupload.servlet.ServletFileUpload

class ServletFileUploadInstrumenterTest extends AgentTestRunner {
class ServletFileUploadInstrumentationTest extends AgentTestRunner {

private Object iastCtx

Expand Down
Loading