Skip to content

Remove ScopeSource enum #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

Remove ScopeSource enum #8565

merged 1 commit into from
Mar 14, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 14, 2025 •
edited by jira bot
Loading

Motivation

Simplify the API between the core tracer and scope/context management

Contributor Checklist

Jira ticket: APMAPI-981

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 14, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 14, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-scope-source-enum
git_commit_date 1741960596 1741963196
git_commit_sha ef1ed74 a111b47
release_version 1.48.0-SNAPSHOT~ef1ed74c68 1.48.0-SNAPSHOT~a111b47d2a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741965484 1741965484
ci_job_id 848590188 848590188
ci_pipeline_id 58854915 58854915
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-moshnsiy-project-304-concurrent-0-13hc1axm 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-moshnsiy-project-304-concurrent-0-13hc1axm 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1037716
Total [baseline] (10.417 s) : 0, 10417368
Agent [candidate] (1.041 s) : 0, 1040590
Total [candidate] (10.523 s) : 0, 10523195
section appsec
Agent [baseline] (1.18 s) : 0, 1179656
Total [baseline] (10.742 s) : 0, 10742364
Agent [candidate] (1.186 s) : 0, 1186142
Total [candidate] (10.778 s) : 0, 10778210
section iast
Agent [baseline] (1.178 s) : 0, 1177688
Total [baseline] (11.043 s) : 0, 11043364
Agent [candidate] (1.172 s) : 0, 1171999
Total [candidate] (10.978 s) : 0, 10978294
section profiling
Agent [baseline] (1.26 s) : 0, 1260171
Total [baseline] (10.837 s) : 0, 10836531
Agent [candidate] (1.26 s) : 0, 1259951
Total [candidate] (10.839 s) : 0, 10838699
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.038 s -
Agent appsec 1.18 s 141.94 ms (13.7%)
Agent iast 1.178 s 139.972 ms (13.5%)
Agent profiling 1.26 s 222.456 ms (21.4%)
Total tracing 10.417 s -
Total appsec 10.742 s 324.996 ms (3.1%)
Total iast 11.043 s 625.996 ms (6.0%)
Total profiling 10.837 s 419.163 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.186 s 145.552 ms (14.0%)
Agent iast 1.172 s 131.409 ms (12.6%)
Agent profiling 1.26 s 219.361 ms (21.1%)
Total tracing 10.523 s -
Total appsec 10.778 s 255.015 ms (2.4%)
Total iast 10.978 s 455.099 ms (4.3%)
Total profiling 10.839 s 315.503 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.683 ms) : 0, 717683
BytebuddyAgent [candidate] (717.385 ms) : 0, 717385
GlobalTracer [baseline] (239.299 ms) : 0, 239299
GlobalTracer [candidate] (239.679 ms) : 0, 239679
AppSec [baseline] (54.702 ms) : 0, 54702
AppSec [candidate] (54.476 ms) : 0, 54476
Remote Config [baseline] (691.028 µs) : 0, 691
Remote Config [candidate] (695.357 µs) : 0, 695
Telemetry [baseline] (10.086 ms) : 0, 10086
Telemetry [candidate] (13.244 ms) : 0, 13244
section appsec
BytebuddyAgent [baseline] (734.156 ms) : 0, 734156
BytebuddyAgent [candidate] (737.471 ms) : 0, 737471
GlobalTracer [baseline] (235.49 ms) : 0, 235490
GlobalTracer [candidate] (237.116 ms) : 0, 237116
IAST [baseline] (21.228 ms) : 0, 21228
IAST [candidate] (21.435 ms) : 0, 21435
AppSec [baseline] (175.274 ms) : 0, 175274
AppSec [candidate] (176.606 ms) : 0, 176606
Remote Config [baseline] (664.739 µs) : 0, 665
Remote Config [candidate] (670.817 µs) : 0, 671
Telemetry [baseline] (8.266 ms) : 0, 8266
Telemetry [candidate] (8.329 ms) : 0, 8329
section iast
BytebuddyAgent [baseline] (842.542 ms) : 0, 842542
BytebuddyAgent [candidate] (837.622 ms) : 0, 837622
GlobalTracer [baseline] (231.41 ms) : 0, 231410
GlobalTracer [candidate] (230.574 ms) : 0, 230574
IAST [baseline] (22.838 ms) : 0, 22838
IAST [candidate] (22.828 ms) : 0, 22828
AppSec [baseline] (56.073 ms) : 0, 56073
AppSec [candidate] (56.365 ms) : 0, 56365
Remote Config [baseline] (630.207 µs) : 0, 630
Remote Config [candidate] (622.319 µs) : 0, 622
Telemetry [baseline] (8.749 ms) : 0, 8749
Telemetry [candidate] (8.758 ms) : 0, 8758
section profiling
BytebuddyAgent [baseline] (709.368 ms) : 0, 709368
BytebuddyAgent [candidate] (709.319 ms) : 0, 709319
GlobalTracer [baseline] (350.06 ms) : 0, 350060
GlobalTracer [candidate] (350.192 ms) : 0, 350192
AppSec [baseline] (54.233 ms) : 0, 54233
AppSec [candidate] (53.283 ms) : 0, 53283
Remote Config [baseline] (668.011 µs) : 0, 668
Remote Config [candidate] (678.204 µs) : 0, 678
Telemetry [baseline] (8.924 ms) : 0, 8924
Telemetry [candidate] (9.122 ms) : 0, 9122
ProfilingAgent [baseline] (96.207 ms) : 0, 96207
ProfilingAgent [candidate] (96.663 ms) : 0, 96663
Profiling [baseline] (96.231 ms) : 0, 96231
Profiling [candidate] (96.688 ms) : 0, 96688
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052168
Total [baseline] (8.7 s) : 0, 8700443
Agent [candidate] (1.049 s) : 0, 1048670
Total [candidate] (8.686 s) : 0, 8686000
section iast
Agent [baseline] (1.169 s) : 0, 1169017
Total [baseline] (9.243 s) : 0, 9243450
Agent [candidate] (1.173 s) : 0, 1172676
Total [candidate] (9.238 s) : 0, 9238035
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1169637
Total [baseline] (9.179 s) : 0, 9179432
Agent [candidate] (1.171 s) : 0, 1171075
Total [candidate] (9.221 s) : 0, 9221248
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167465
Total [baseline] (9.235 s) : 0, 9235189
Agent [candidate] (1.174 s) : 0, 1173740
Total [candidate] (9.236 s) : 0, 9236052
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.169 s 116.848 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 117.468 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.167 s 115.296 ms (11.0%)
Total tracing 8.7 s -
Total iast 9.243 s 543.007 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.179 s 478.988 ms (5.5%)
Total iast_TELEMETRY_OFF 9.235 s 534.746 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.173 s 124.006 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 122.405 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.174 s 125.071 ms (11.9%)
Total tracing 8.686 s -
Total iast 9.238 s 552.036 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.221 s 535.248 ms (6.2%)
Total iast_TELEMETRY_OFF 9.236 s 550.052 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.104 ms) : 0, 726104
BytebuddyAgent [candidate] (723.703 ms) : 0, 723703
GlobalTracer [baseline] (240.624 ms) : 0, 240624
GlobalTracer [candidate] (241.022 ms) : 0, 241022
AppSec [baseline] (55.025 ms) : 0, 55025
AppSec [candidate] (54.883 ms) : 0, 54883
Remote Config [baseline] (693.484 µs) : 0, 693
Remote Config [candidate] (699.812 µs) : 0, 700
Telemetry [baseline] (14.425 ms) : 0, 14425
Telemetry [candidate] (13.058 ms) : 0, 13058
section iast
BytebuddyAgent [baseline] (835.761 ms) : 0, 835761
BytebuddyAgent [candidate] (838.586 ms) : 0, 838586
GlobalTracer [baseline] (230.112 ms) : 0, 230112
GlobalTracer [candidate] (230.613 ms) : 0, 230613
IAST [baseline] (22.575 ms) : 0, 22575
IAST [candidate] (22.896 ms) : 0, 22896
AppSec [baseline] (56.037 ms) : 0, 56037
AppSec [candidate] (55.959 ms) : 0, 55959
Remote Config [baseline] (613.82 µs) : 0, 614
Remote Config [candidate] (615.187 µs) : 0, 615
Telemetry [baseline] (8.713 ms) : 0, 8713
Telemetry [candidate] (8.748 ms) : 0, 8748
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.203 ms) : 0, 836203
BytebuddyAgent [candidate] (836.701 ms) : 0, 836701
GlobalTracer [baseline] (229.787 ms) : 0, 229787
GlobalTracer [candidate] (230.7 ms) : 0, 230700
IAST [baseline] (22.896 ms) : 0, 22896
IAST [candidate] (22.737 ms) : 0, 22737
AppSec [baseline] (56.224 ms) : 0, 56224
AppSec [candidate] (56.327 ms) : 0, 56327
Remote Config [baseline] (610.61 µs) : 0, 611
Remote Config [candidate] (608.153 µs) : 0, 608
Telemetry [baseline] (8.714 ms) : 0, 8714
Telemetry [candidate] (8.704 ms) : 0, 8704
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.225 ms) : 0, 834225
BytebuddyAgent [candidate] (839.574 ms) : 0, 839574
GlobalTracer [baseline] (230.817 ms) : 0, 230817
GlobalTracer [candidate] (230.789 ms) : 0, 230789
IAST [baseline] (22.38 ms) : 0, 22380
IAST [candidate] (22.481 ms) : 0, 22481
AppSec [baseline] (55.527 ms) : 0, 55527
AppSec [candidate] (56.256 ms) : 0, 56256
Remote Config [baseline] (609.971 µs) : 0, 610
Remote Config [candidate] (633.314 µs) : 0, 633
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.666 ms) : 0, 8666
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-14T14:48:20 2025-03-14T14:56:07
git_branch master mcculls/remove-scope-source-enum
git_commit_date 1741960596 1741963196
git_commit_sha ef1ed74 a111b47
release_version 1.48.0-SNAPSHOT~ef1ed74c68 1.48.0-SNAPSHOT~a111b47d2a
start_time 2025-03-14T14:48:06 2025-03-14T14:55:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741964567 1741964567
ci_job_id 848590190 848590190
ci_pipeline_id 58854915 58854915
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-dgzduy7c-project-304-concurrent-0-wwn2b5p2 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-dgzduy7c-project-304-concurrent-0-wwn2b5p2 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.891 µs) : 364, 404
.   : milestone, 384,
iast (525.255 µs) : 503, 548
.   : milestone, 525,
iast_FULL (738.517 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (570.159 µs) : 548, 592
.   : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (513.871 µs) : 492, 535
.   : milestone, 514,
iast_INACTIVE (469.301 µs) : 448, 490
.   : milestone, 469,
iast_TELEMETRY_OFF (510.615 µs) : 488, 533
.   : milestone, 511,
tracing (466.3 µs) : 445, 487
.   : milestone, 466,
section candidate
no_agent (380.548 µs) : 360, 401
.   : milestone, 381,
iast (516.656 µs) : 495, 538
.   : milestone, 517,
iast_FULL (742.881 µs) : 721, 765
.   : milestone, 743,
iast_GLOBAL (564.262 µs) : 542, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (517.378 µs) : 496, 539
.   : milestone, 517,
iast_INACTIVE (470.008 µs) : 448, 492
.   : milestone, 470,
iast_TELEMETRY_OFF (514.106 µs) : 491, 537
.   : milestone, 514,
tracing (466.274 µs) : 445, 487
.   : milestone, 466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.891 µs [364.184 µs, 403.598 µs] -
iast 525.255 µs [502.902 µs, 547.609 µs] 141.365 µs (36.8%)
iast_FULL 738.517 µs [716.507 µs, 760.528 µs] 354.626 µs (92.4%)
iast_GLOBAL 570.159 µs [548.338 µs, 591.981 µs] 186.269 µs (48.5%)
iast_HARDCODED_SECRET_DISABLED 513.871 µs [492.286 µs, 535.455 µs] 129.98 µs (33.9%)
iast_INACTIVE 469.301 µs [448.203 µs, 490.399 µs] 85.41 µs (22.2%)
iast_TELEMETRY_OFF 510.615 µs [487.775 µs, 533.454 µs] 126.724 µs (33.0%)
tracing 466.3 µs [445.37 µs, 487.231 µs] 82.409 µs (21.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.548 µs [360.284 µs, 400.812 µs] -
iast 516.656 µs [495.052 µs, 538.259 µs] 136.108 µs (35.8%)
iast_FULL 742.881 µs [720.693 µs, 765.068 µs] 362.333 µs (95.2%)
iast_GLOBAL 564.262 µs [542.338 µs, 586.185 µs] 183.713 µs (48.3%)
iast_HARDCODED_SECRET_DISABLED 517.378 µs [495.992 µs, 538.763 µs] 136.829 µs (36.0%)
iast_INACTIVE 470.008 µs [448.121 µs, 491.895 µs] 89.46 µs (23.5%)
iast_TELEMETRY_OFF 514.106 µs [491.097 µs, 537.115 µs] 133.558 µs (35.1%)
tracing 466.274 µs [445.369 µs, 487.179 µs] 85.726 µs (22.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1387
.   : milestone, 1368,
appsec (1.747 ms) : 1724, 1771
.   : milestone, 1747,
appsec_no_iast (1.754 ms) : 1730, 1779
.   : milestone, 1754,
code_origins (1.68 ms) : 1651, 1708
.   : milestone, 1680,
iast (1.533 ms) : 1509, 1558
.   : milestone, 1533,
profiling (1.526 ms) : 1503, 1549
.   : milestone, 1526,
tracing (1.516 ms) : 1491, 1541
.   : milestone, 1516,
section candidate
no_agent (1.379 ms) : 1359, 1400
.   : milestone, 1379,
appsec (1.743 ms) : 1719, 1767
.   : milestone, 1743,
appsec_no_iast (1.759 ms) : 1733, 1785
.   : milestone, 1759,
code_origins (1.693 ms) : 1665, 1721
.   : milestone, 1693,
iast (1.525 ms) : 1500, 1550
.   : milestone, 1525,
profiling (1.526 ms) : 1503, 1549
.   : milestone, 1526,
tracing (1.502 ms) : 1477, 1528
.   : milestone, 1502,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.348 ms, 1.387 ms] -
appsec 1.747 ms [1.724 ms, 1.771 ms] 379.616 µs (27.8%)
appsec_no_iast 1.754 ms [1.73 ms, 1.779 ms] 386.807 µs (28.3%)
code_origins 1.68 ms [1.651 ms, 1.708 ms] 312.062 µs (22.8%)
iast 1.533 ms [1.509 ms, 1.558 ms] 165.705 µs (12.1%)
profiling 1.526 ms [1.503 ms, 1.549 ms] 158.371 µs (11.6%)
tracing 1.516 ms [1.491 ms, 1.541 ms] 148.371 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.379 ms [1.359 ms, 1.4 ms] -
appsec 1.743 ms [1.719 ms, 1.767 ms] 363.788 µs (26.4%)
appsec_no_iast 1.759 ms [1.733 ms, 1.785 ms] 379.689 µs (27.5%)
code_origins 1.693 ms [1.665 ms, 1.721 ms] 313.817 µs (22.8%)
iast 1.525 ms [1.5 ms, 1.55 ms] 145.635 µs (10.6%)
profiling 1.526 ms [1.503 ms, 1.549 ms] 146.749 µs (10.6%)
tracing 1.502 ms [1.477 ms, 1.528 ms] 123.103 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-scope-source-enum
git_commit_date 1741960596 1741963196
git_commit_sha ef1ed74 a111b47
release_version 1.48.0-SNAPSHOT~ef1ed74c68 1.48.0-SNAPSHOT~a111b47d2a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741965131 1741965131
ci_job_id 848590192 848590192
ci_pipeline_id 58854915 58854915
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-gzhmqs6t-project-304-concurrent-0-wrqdoj3v 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-gzhmqs6t-project-304-concurrent-0-wrqdoj3v 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.305 s) : 15305000, 15305000
.   : milestone, 15305000,
appsec (15.157 s) : 15157000, 15157000
.   : milestone, 15157000,
iast (18.268 s) : 18268000, 18268000
.   : milestone, 18268000,
iast_GLOBAL (18.132 s) : 18132000, 18132000
.   : milestone, 18132000,
profiling (15.132 s) : 15132000, 15132000
.   : milestone, 15132000,
tracing (15.048 s) : 15048000, 15048000
.   : milestone, 15048000,
section candidate
no_agent (15.444 s) : 15444000, 15444000
.   : milestone, 15444000,
appsec (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
iast (18.5 s) : 18500000, 18500000
.   : milestone, 18500000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
.   : milestone, 17972000,
profiling (15.508 s) : 15508000, 15508000
.   : milestone, 15508000,
tracing (14.893 s) : 14893000, 14893000
.   : milestone, 14893000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.305 s [15.305 s, 15.305 s] -
appsec 15.157 s [15.157 s, 15.157 s] -148.0 ms (-1.0%)
iast 18.268 s [18.268 s, 18.268 s] 2.963 s (19.4%)
iast_GLOBAL 18.132 s [18.132 s, 18.132 s] 2.827 s (18.5%)
profiling 15.132 s [15.132 s, 15.132 s] -173.0 ms (-1.1%)
tracing 15.048 s [15.048 s, 15.048 s] -257.0 ms (-1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.444 s [15.444 s, 15.444 s] -
appsec 15.149 s [15.149 s, 15.149 s] -295.0 ms (-1.9%)
iast 18.5 s [18.5 s, 18.5 s] 3.056 s (19.8%)
iast_GLOBAL 17.972 s [17.972 s, 17.972 s] 2.528 s (16.4%)
profiling 15.508 s [15.508 s, 15.508 s] 64.0 ms (0.4%)
tracing 14.893 s [14.893 s, 14.893 s] -551.0 ms (-3.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~a111b47d2a, baseline=1.48.0-SNAPSHOT~ef1ed74c68
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1476
.   : milestone, 1465,
appsec (2.342 ms) : 2298, 2386
.   : milestone, 2342,
iast (2.119 ms) : 2063, 2174
.   : milestone, 2119,
iast_GLOBAL (2.161 ms) : 2105, 2217
.   : milestone, 2161,
profiling (1.961 ms) : 1917, 2005
.   : milestone, 1961,
tracing (1.949 ms) : 1907, 1992
.   : milestone, 1949,
section candidate
no_agent (1.472 ms) : 1460, 1484
.   : milestone, 1472,
appsec (2.339 ms) : 2295, 2383
.   : milestone, 2339,
iast (2.123 ms) : 2067, 2178
.   : milestone, 2123,
iast_GLOBAL (2.158 ms) : 2102, 2214
.   : milestone, 2158,
profiling (1.965 ms) : 1921, 2009
.   : milestone, 1965,
tracing (1.941 ms) : 1899, 1984
.   : milestone, 1941,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.476 ms] -
appsec 2.342 ms [2.298 ms, 2.386 ms] 876.572 µs (59.8%)
iast 2.119 ms [2.063 ms, 2.174 ms] 653.75 µs (44.6%)
iast_GLOBAL 2.161 ms [2.105 ms, 2.217 ms] 696.324 µs (47.5%)
profiling 1.961 ms [1.917 ms, 2.005 ms] 496.188 µs (33.9%)
tracing 1.949 ms [1.907 ms, 1.992 ms] 484.172 µs (33.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.484 ms] -
appsec 2.339 ms [2.295 ms, 2.383 ms] 867.039 µs (58.9%)
iast 2.123 ms [2.067 ms, 2.178 ms] 650.596 µs (44.2%)
iast_GLOBAL 2.158 ms [2.102 ms, 2.214 ms] 686.178 µs (46.6%)
profiling 1.965 ms [1.921 ms, 2.009 ms] 493.294 µs (33.5%)
tracing 1.941 ms [1.899 ms, 1.984 ms] 469.257 µs (31.9%)

@mcculls mcculls marked this pull request as ready for review March 14, 2025 15:31
@mcculls mcculls requested review from a team as code owners March 14, 2025 15:31
@mcculls mcculls requested review from smola and PerfectSlayer March 14, 2025 15:31
@mcculls mcculls enabled auto-merge (squash) March 14, 2025 15:38
@mcculls mcculls merged commit c06a408 into master Mar 14, 2025
262 of 265 checks passed
@mcculls mcculls deleted the mcculls/remove-scope-source-enum branch March 14, 2025 15:44
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 14, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Remove ScopeSource enum (#8565)
f646940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer