-
Notifications
You must be signed in to change notification settings - Fork 303
HTTP response schema collection and data classification #8840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sezen-datadog
wants to merge
2
commits into
master
Choose a base branch
from
sezen.leblay/APPSEC-57259
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
891c835
to
a2809f5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025585
Total [baseline] (8.652 s) : 0, 8652399
Agent [candidate] (1.025 s) : 0, 1025300
Total [candidate] (8.709 s) : 0, 8709278
section iast
Agent [baseline] (1.146 s) : 0, 1146159
Total [baseline] (9.232 s) : 0, 9231729
Agent [candidate] (1.153 s) : 0, 1152929
Total [candidate] (9.277 s) : 0, 9277371
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.151 s) : 0, 1150790
Total [baseline] (9.209 s) : 0, 9208535
Agent [candidate] (1.161 s) : 0, 1160816
Total [candidate] (9.193 s) : 0, 9193371
section iast_TELEMETRY_OFF
Agent [baseline] (1.144 s) : 0, 1144184
Total [baseline] (9.218 s) : 0, 9218289
Agent [candidate] (1.147 s) : 0, 1147276
Total [candidate] (9.277 s) : 0, 9276858
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.183 ms) : 0, 687183
BytebuddyAgent [candidate] (683.822 ms) : 0, 683822
GlobalTracer [baseline] (239.976 ms) : 0, 239976
GlobalTracer [candidate] (240.083 ms) : 0, 240083
AppSec [baseline] (55.309 ms) : 0, 55309
AppSec [candidate] (57.426 ms) : 0, 57426
Debugger [baseline] (9.85 ms) : 0, 9850
Debugger [candidate] (6.316 ms) : 0, 6316
Remote Config [baseline] (686.31 µs) : 0, 686
Remote Config [candidate] (683.384 µs) : 0, 683
Telemetry [baseline] (8.954 ms) : 0, 8954
Telemetry [candidate] (13.507 ms) : 0, 13507
section iast
BytebuddyAgent [baseline] (799.473 ms) : 0, 799473
BytebuddyAgent [candidate] (804.744 ms) : 0, 804744
GlobalTracer [baseline] (229.728 ms) : 0, 229728
GlobalTracer [candidate] (231.044 ms) : 0, 231044
IAST [baseline] (28.4 ms) : 0, 28400
IAST [candidate] (30.643 ms) : 0, 30643
AppSec [baseline] (50.613 ms) : 0, 50613
AppSec [candidate] (48.512 ms) : 0, 48512
Debugger [baseline] (5.973 ms) : 0, 5973
Debugger [candidate] (5.893 ms) : 0, 5893
Remote Config [baseline] (607.896 µs) : 0, 608
Remote Config [candidate] (579.046 µs) : 0, 579
Telemetry [baseline] (7.936 ms) : 0, 7936
Telemetry [candidate] (7.998 ms) : 0, 7998
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.378 ms) : 0, 803378
BytebuddyAgent [candidate] (810.417 ms) : 0, 810417
GlobalTracer [baseline] (231.059 ms) : 0, 231059
GlobalTracer [candidate] (232.499 ms) : 0, 232499
IAST [baseline] (29.859 ms) : 0, 29859
IAST [candidate] (28.628 ms) : 0, 28628
AppSec [baseline] (48.615 ms) : 0, 48615
AppSec [candidate] (51.23 ms) : 0, 51230
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (5.855 ms) : 0, 5855
Remote Config [baseline] (590.918 µs) : 0, 591
Remote Config [candidate] (603.259 µs) : 0, 603
Telemetry [baseline] (7.878 ms) : 0, 7878
Telemetry [candidate] (7.851 ms) : 0, 7851
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.827 ms) : 0, 797827
BytebuddyAgent [candidate] (799.946 ms) : 0, 799946
GlobalTracer [baseline] (230.235 ms) : 0, 230235
GlobalTracer [candidate] (230.917 ms) : 0, 230917
IAST [baseline] (23.132 ms) : 0, 23132
IAST [candidate] (24.409 ms) : 0, 24409
AppSec [baseline] (55.137 ms) : 0, 55137
AppSec [candidate] (54.117 ms) : 0, 54117
Debugger [baseline] (5.91 ms) : 0, 5910
Debugger [candidate] (5.942 ms) : 0, 5942
Remote Config [baseline] (595.947 µs) : 0, 596
Remote Config [candidate] (599.843 µs) : 0, 600
Telemetry [baseline] (7.788 ms) : 0, 7788
Telemetry [candidate] (7.891 ms) : 0, 7891
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1024825
Total [baseline] (10.517 s) : 0, 10517239
Agent [candidate] (1.024 s) : 0, 1024209
Total [candidate] (10.565 s) : 0, 10564928
section appsec
Agent [baseline] (1.166 s) : 0, 1165856
Total [baseline] (10.737 s) : 0, 10736509
Agent [candidate] (1.167 s) : 0, 1166946
Total [candidate] (10.7 s) : 0, 10700273
section iast
Agent [baseline] (1.15 s) : 0, 1150256
Total [baseline] (10.931 s) : 0, 10930525
Agent [candidate] (1.158 s) : 0, 1157738
Total [candidate] (10.988 s) : 0, 10988332
section profiling
Agent [baseline] (1.293 s) : 0, 1292899
Total [baseline] (11.0 s) : 0, 11000461
Agent [candidate] (1.274 s) : 0, 1273792
Total [candidate] (10.823 s) : 0, 10822904
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.104 ms) : 0, 687104
BytebuddyAgent [candidate] (685.431 ms) : 0, 685431
GlobalTracer [baseline] (241.21 ms) : 0, 241210
GlobalTracer [candidate] (240.56 ms) : 0, 240560
AppSec [baseline] (55.165 ms) : 0, 55165
AppSec [candidate] (58.912 ms) : 0, 58912
Debugger [baseline] (7.09 ms) : 0, 7090
Debugger [candidate] (6.248 ms) : 0, 6248
Remote Config [baseline] (714.905 µs) : 0, 715
Remote Config [candidate] (654.155 µs) : 0, 654
Telemetry [baseline] (9.952 ms) : 0, 9952
Telemetry [candidate] (8.819 ms) : 0, 8819
section appsec
BytebuddyAgent [baseline] (703.433 ms) : 0, 703433
BytebuddyAgent [candidate] (703.006 ms) : 0, 703006
GlobalTracer [baseline] (237.309 ms) : 0, 237309
GlobalTracer [candidate] (237.838 ms) : 0, 237838
IAST [baseline] (21.737 ms) : 0, 21737
IAST [candidate] (21.593 ms) : 0, 21593
AppSec [baseline] (176.258 ms) : 0, 176258
AppSec [candidate] (177.822 ms) : 0, 177822
Debugger [baseline] (6.305 ms) : 0, 6305
Debugger [candidate] (5.945 ms) : 0, 5945
Remote Config [baseline] (636.634 µs) : 0, 637
Remote Config [candidate] (617.57 µs) : 0, 618
Telemetry [baseline] (7.405 ms) : 0, 7405
Telemetry [candidate] (7.36 ms) : 0, 7360
section iast
BytebuddyAgent [baseline] (802.94 ms) : 0, 802940
BytebuddyAgent [candidate] (808.441 ms) : 0, 808441
GlobalTracer [baseline] (230.745 ms) : 0, 230745
GlobalTracer [candidate] (231.64 ms) : 0, 231640
IAST [baseline] (27.621 ms) : 0, 27621
IAST [candidate] (29.232 ms) : 0, 29232
AppSec [baseline] (49.45 ms) : 0, 49450
AppSec [candidate] (50.423 ms) : 0, 50423
Debugger [baseline] (5.922 ms) : 0, 5922
Debugger [candidate] (5.865 ms) : 0, 5865
Remote Config [baseline] (589.228 µs) : 0, 589
Remote Config [candidate] (584.482 µs) : 0, 584
Telemetry [baseline] (7.92 ms) : 0, 7920
Telemetry [candidate] (7.904 ms) : 0, 7904
section profiling
BytebuddyAgent [baseline] (679.716 ms) : 0, 679716
BytebuddyAgent [candidate] (678.293 ms) : 0, 678293
GlobalTracer [baseline] (382.169 ms) : 0, 382169
GlobalTracer [candidate] (360.735 ms) : 0, 360735
AppSec [baseline] (55.053 ms) : 0, 55053
AppSec [candidate] (63.361 ms) : 0, 63361
Debugger [baseline] (6.197 ms) : 0, 6197
Debugger [candidate] (6.303 ms) : 0, 6303
Remote Config [baseline] (669.396 µs) : 0, 669
Remote Config [candidate] (668.76 µs) : 0, 669
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.433 ms) : 0, 8433
ProfilingAgent [baseline] (110.001 ms) : 0, 110001
ProfilingAgent [candidate] (104.818 ms) : 0, 104818
Profiling [baseline] (110.028 ms) : 0, 110028
Profiling [candidate] (104.842 ms) : 0, 104842
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1338, 1379
. : milestone, 1359,
appsec (1.739 ms) : 1716, 1763
. : milestone, 1739,
appsec_no_iast (1.716 ms) : 1692, 1739
. : milestone, 1716,
code_origins (1.694 ms) : 1667, 1721
. : milestone, 1694,
iast (1.52 ms) : 1496, 1543
. : milestone, 1520,
profiling (1.549 ms) : 1524, 1574
. : milestone, 1549,
tracing (1.498 ms) : 1473, 1522
. : milestone, 1498,
section candidate
no_agent (1.379 ms) : 1359, 1398
. : milestone, 1379,
appsec (1.746 ms) : 1722, 1769
. : milestone, 1746,
appsec_no_iast (1.758 ms) : 1735, 1781
. : milestone, 1758,
code_origins (1.668 ms) : 1641, 1695
. : milestone, 1668,
iast (1.545 ms) : 1521, 1570
. : milestone, 1545,
profiling (1.574 ms) : 1550, 1597
. : milestone, 1574,
tracing (1.501 ms) : 1476, 1526
. : milestone, 1501,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (381.762 µs) : 362, 402
. : milestone, 382,
iast (513.555 µs) : 492, 535
. : milestone, 514,
iast_FULL (736.993 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (556.64 µs) : 535, 578
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (518.826 µs) : 496, 541
. : milestone, 519,
iast_INACTIVE (460.148 µs) : 438, 482
. : milestone, 460,
iast_TELEMETRY_OFF (506.158 µs) : 483, 530
. : milestone, 506,
tracing (459.563 µs) : 438, 482
. : milestone, 460,
section candidate
no_agent (380.778 µs) : 360, 401
. : milestone, 381,
iast (526.484 µs) : 504, 549
. : milestone, 526,
iast_FULL (740.908 µs) : 717, 764
. : milestone, 741,
iast_GLOBAL (573.787 µs) : 550, 598
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (515.431 µs) : 494, 537
. : milestone, 515,
iast_INACTIVE (463.91 µs) : 441, 487
. : milestone, 464,
iast_TELEMETRY_OFF (511.133 µs) : 489, 533
. : milestone, 511,
tracing (458.217 µs) : 437, 480
. : milestone, 458,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.388 ms) : 2340, 2436
. : milestone, 2388,
iast (2.173 ms) : 2112, 2234
. : milestone, 2173,
iast_GLOBAL (2.212 ms) : 2150, 2273
. : milestone, 2212,
profiling (2.011 ms) : 1962, 2060
. : milestone, 2011,
tracing (1.996 ms) : 1949, 2044
. : milestone, 1996,
section candidate
no_agent (1.472 ms) : 1460, 1484
. : milestone, 1472,
appsec (2.387 ms) : 2339, 2436
. : milestone, 2387,
iast (2.176 ms) : 2114, 2237
. : milestone, 2176,
iast_GLOBAL (2.218 ms) : 2156, 2280
. : milestone, 2218,
profiling (2.017 ms) : 1968, 2066
. : milestone, 2017,
tracing (2.003 ms) : 1955, 2050
. : milestone, 2003,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6e49d48954, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
appsec (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
iast (18.445 s) : 18445000, 18445000
. : milestone, 18445000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
tracing (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
section candidate
no_agent (15.327 s) : 15327000, 15327000
. : milestone, 15327000,
appsec (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
iast (19.015 s) : 19015000, 19015000
. : milestone, 19015000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
profiling (15.751 s) : 15751000, 15751000
. : milestone, 15751000,
tracing (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
|
ff2d34f
to
4d7fed2
Compare
f686487
to
c4de9a0
Compare
531668a
to
0de5260
Compare
5bee816
to
6e49d48
Compare
Signed-off-by: sezen.leblay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57259