Skip to content

chore(profiling): remove flaky marker on test_accuracy #13146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

chore(profiling): remove flaky marker on test_accuracy #13146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a459ac7
chore(profiling): remove flaky marker on test_accuray
taegyunkim Apr 9, 2025
b645c02
update comment
taegyunkim Apr 9, 2025
c9a0663
format
taegyunkim Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/profiling/test_accuracy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

import pytest

from tests.utils import flaky


def spend_1():
time.sleep(1)
Expand Down Expand Up @@ -46,8 +44,8 @@ def spend_cpu_3():
pass


# We allow 5% error:
TOLERANCE = 0.05
# We allow 7% error:
TOLERANCE = 0.07


def assert_almost_equal(value, target, tolerance=TOLERANCE):
Expand All @@ -63,7 +61,6 @@ def total_time(time_data, funcname):


@pytest.mark.subprocess(env=dict(DD_PROFILING_MAX_TIME_USAGE_PCT="100"))
@flaky(until=1743703564, reason="3177585388 is not approximately equal to 3000000000.0 within tolerance=0.05")
def test_accuracy():
import collections

Expand Down
Loading