Skip to content

Duplicate node announcements in gossip_store #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
endothermicdev opened this issue Aug 7, 2023 · 0 comments · Fixed by #6543 or #6549
Closed

Duplicate node announcements in gossip_store #6531

endothermicdev opened this issue Aug 7, 2023 · 0 comments · Fixed by #6543 or #6549
Assignees
@endothermicdev
Labels
bug gossip
Milestone
v23.08

Comments

@endothermicdev
Copy link
Collaborator

Issue and Steps to Reproduce

Duplicate node announcement entries in the gossip_store cause a gossip_store corruption.

2023-08-07T17:24:19.606Z DEBUG   gossipd: gossip_store_compact_offline: 289959 deleted, 283617 copied
2023-08-07T17:24:19.611Z **BROKEN** gossipd: gossip_store broadcastable node_announcement 45096383 replaces 23317789!
2023-08-07T17:24:19.611Z **BROKEN** gossipd: gossip_store: Bad node_announcement (01010eac2600fc9d9c9b5d2b9ae81f2b93a0229a3d74c9219c00bcd6d69250c5fc7470fd74861abd78a101c3922db3dbefbba17e79fc3777c6eddc47273f4b314bc700fd800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000802000888252a164cecc6b03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e268f4424c4e444d5950414c000000000000000000000000000000000000000000000000002d01bf05aa0826090491e8a74c2446c43ec732d7937dc80e161e78cc6970295dc2d0bc980aad1f6d55bb7c032607). Moving to gossip_store.corrupt and truncating

The gossip_store contains the following for the node at hand:

<@8302799   channel 757406x1033x1 nodes: 03c6d1cce30eaaa8b4ad436735c6816ae886f588ff8362017af940ad5a89118014 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@8351263   channel 757680x1808x2 nodes: 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@8554905   channel 758647x2294x1 nodes: 033d8656219478701227199cbd6f670335c8d408a92ae88b962c49d4dc0e83e025 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@9308933   channel 760951x1671x1 nodes: 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@23317789  node_id:03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2 ts:1690102486 feat_len: 253 flags:0000 EXPIRED>
<@41217227  cupdate 757680x1808x2 ts:1691135294 dir:1 flags:0000>
<@41258977  cupdate 760951x1671x1 ts:1691137094 dir:1 flags:0000>
<@42658829  cupdate 757406x1033x1 ts:1691183894 dir:1 flags:0000>
<@44916619  cupdate 757680x1808x2 ts:1691268077 dir:0 flags:0000>
<@44917964  cupdate 760951x1671x1 ts:1691268077 dir:0 flags:0000>
<@45096383  node_id:03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2 ts:1691274347 feat_len: 253 flags:0000>
<@45119968  cupdate 760951x1671x1 ts:1691275089 dir:0 flags:2000 DISABLED SPAM>
  disabled by node 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182
<@45121918  cupdate 757680x1808x2 ts:1691275089 dir:0 flags:2000 DISABLED SPAM>
  disabled by node 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182
<@45131433  cupdate 757406x1033x1 ts:1691275496 dir:0 flags:0000>
<@45137578  cupdate 758647x2294x1 ts:1691275893 dir:0 flags:0000>
<@48019905  cupdate 758647x2294x1 ts:1691344543 dir:1 flags:0000>

reported by @wtogami running commit 54bcb10
@endothermicdev endothermicdev added this to the v23.08 milestone Aug 7, 2023
@endothermicdev endothermicdev self-assigned this Aug 7, 2023
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Aug 10, 2023
@rustyrussell
gossipd: ignore redundant node_announcement in gossip_store.
86eb66b 
Don't know how this is happening, but it is not harmful to ignore it for now.

Fixes: ElementsProject#6531
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell mentioned this issue Aug 10, 2023
Merged
rustyrussell added a commit that referenced this issue Aug 11, 2023
@rustyrussell
gossipd: ignore redundant node_announcement in gossip_store.
846cec4 
Don't know how this is happening, but it is not harmful to ignore it for now.

Fixes: #6531
Signed-off-by: Rusty Russell <[email protected]>
endothermicdev added a commit to endothermicdev/lightning that referenced this issue Aug 11, 2023
@endothermicdev
gossipd: load pending spam node announcements without forgetting prev…
3bf9ee5 
…ious node announcements

Fixes: ElementsProject#6531
@endothermicdev endothermicdev mentioned this issue Aug 11, 2023
Merged
endothermicdev added a commit to endothermicdev/lightning that referenced this issue Aug 11, 2023
@endothermicdev
gossipd: load pending spam node announcements without forgetting prev…
322414d 
…ious node announcements

Fixes: ElementsProject#6531
endothermicdev added a commit to endothermicdev/lightning that referenced this issue Aug 11, 2023
@endothermicdev
gossipd: load pending spam node announcements without forgetting prev…
e0564ff 
…ious node announcements

Fixes: ElementsProject#6531
litch pushed a commit to litch/lightning that referenced this issue Aug 11, 2023
@rustyrussell @litch
gossipd: ignore redundant node_announcement in gossip_store.
e027e27 
Don't know how this is happening, but it is not harmful to ignore it for now.

Fixes: ElementsProject#6531
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell pushed a commit that referenced this issue Aug 11, 2023
@endothermicdev @rustyrussell
gossipd: load pending spam node announcements without forgetting prev…
d8d2032 
…ious node announcements

Fixes: #6531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endothermicdev endothermicdev

Labels
bug gossip
Projects
None yet
Milestone
v23.08
1 participant
@endothermicdev