Double nannounce patch #6549
Merged
Double nannounce patch #6549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endothermicdev
force-pushed
the
double-nannounce-patch
branch
from
3bf9ee5 to
322414d
Compare
…ious node announcements Fixes: ElementsProject#6531
endothermicdev
force-pushed
the
double-nannounce-patch
branch
from
322414d to
e0564ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading from the gossip store under a particular scenario:
channel announcement
node announcement
node announcement (spam)
channel update
There should be two node announcements pending the first channel update. This case was not handled and the spam announcement was overwriting the broadcastable announcement causing gossipd to lose track of it. The answer is to properly load the spam announcement alongside the broadcastable one once the channel is created.
Fixes: #6531