Larger internal messages #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s specified. For our own internal comms CSVs, we should always name explicit types. Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#289 Signed-off-by: Rusty Russell <[email protected]>
cdecker
requested changes
Sep 28, 2017
wire/wire_io.c
Outdated
| if (arg->u2.s == INSIDE_HEADER_BIT + HEADER_LEN) { | ||
| arg->u2.s = be16_to_cpu(*(be16 *)p); | ||
| arg->u2.s = *(wire_len_t *)p; |
There was a problem hiding this comment.
Ever since implementing the Bitcoin protocol I have a very strong aversion against using native host byte order for anything that could potentially be used in a networked scenario. I know we currently don't send this anywhere but the same host, but I'd use network byte order anyway.
There was a problem hiding this comment.
Yes, was a line-ball for me. I'll fix.
We don't anticipate daemons across machines, but you never know. Suggested-by: Christian Decker Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Christian Decker <[email protected]>
cdecker
approved these changes
Sep 29, 2017
|
Had to rerun CI a few times, we have a flaky test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: include stress test that triggered it.