catchup #3
Merged
catchup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of clearing them entirely, this is more
consistent with what the react-chart-editor expects
- this piece here is called by Colorbar.supplyDefaults, but colorbars do not have a container-wide 'color' attribute unlike axes, so the comparison with layoutAttributes.color was off. - this bug did not affect the baselines as this routine is called again during Colorbar.draw with a set container color.
... this reduces the occurance of intermittent failure in
the gl2d_click suite on etpinard's laptop
This reverts commit f43cada.
The title can be shown either inside the hole (if there is one), or outside. If the title is placed outside, the algorithm tries to position it so that it does not intersect labels or pulled slices.
this sets clientX and clientY to the values from the first touch in TouchEvent.changedTouches
Add missing fields to fullData
…scatter traces
and along the way speed up trace deletion in general, by not redrawing all the points in the deleted trace immediately before removing them!
Fix stacked area layering and deletion bugs
- in the process, pull out clipEnds, anyCounterAxLineAtZero and hasBarsOrFill - attach 'clipped' grid values to ax._valsClipped
- lock down showline/zeroline behavior - draw zeroline above grid lines - adapt regl grid test values
- tick0 and dtick *do* have defaults (filled in supplyDefaults), which make them compatible with the stock diffing algorithm.
- coerce polar?.bargap and polar?.barmode only for subplots with visible barpolar traces on them.
Fix #3022 - validate + polar.bargap
If it is undefined, titleposition is set to 'middle center', if hole > 0, and to 'top center' otherwise. _verifyTitle now returns a promise.
- before this commit 'text' values were shown first i.e. above r and theta values in the hover labels.
Polar 'text' in hover labels fixes
Fix pie's support for individual stroke width values [2989]
- when hovermode:'y' and one trace with multiple hover labels - when hovermode:'closest' and at leat one trace is 'horizontal' on the subplot. - lock behavior in violin suite.
... and fix tests that were asserting white on white
hover label text.
fallback to max-width and max-height if necessary
... and if the corresponding trace is 'horizontal'
- this makes the trace name visible with e.g. hoverlabel.bgcolor: 'white'
Fix hover label coloring on white bgcolor
…bels Rotate hover labels in a few more scenarios
- this didn't lead to any bugs, as the correct editType was resolved, it lead to false Lib.warn message.
…ray-cont Do not to look for 'add' or 'remove' when replacing array containers
Pie title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catchup