[Bookmarks] Rename init parameter, update example usage #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeinzimer
commented
Mar 30, 2023
Comment on lines
-61
to
-64
| // Bookmarks( | ||
| // isPresented: $showingBookmarks, | ||
| // mapOrScene: map | ||
| // ) |
There was a problem hiding this comment.
This would've caused a build error if it were to be uncommented by a user since map was moved under dataModel.
Comment on lines
+56
to
+60
| .onSelectionChanged { bookmark in | ||
| if let viewpoint = bookmark.viewpoint { | ||
| Task { await mapViewProxy.setViewpoint(viewpoint, duration: 1) } | ||
| } | ||
| } |
There was a problem hiding this comment.
Since we support viewpoint animation now, we can uncomment this and make good use of it.
dfeinzimer
changed the title
dfeinzimer
commented
Mar 30, 2023
| /// - mapOrScene: A `GeoModel` authored with pre-existing bookmarks. | ||
| /// - geoModel: A `GeoModel` authored with pre-existing bookmarks. |
There was a problem hiding this comment.
Basemap gallery uses this name for a parameter of the same type.
11 tasks
mhdostal
approved these changes
Mar 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #260