[Compass] Remove action parameter, add mapViewProxy parameter, support rotation animation
#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dfeinzimer
commented
Apr 11, 2023
•
dfeinzimer
commented
- Closes Revise Compass animation #295
- In Swift 3882, a conclusion was reached that toolkit components should take proxy parameters where needed.
- In the case of the Compass, a map view proxy is used to animate the map view's heading to zero.
- SceneView compass animations will not be supported.
- See also Integrate new animated viewpoint functionality #260
11 tasks
dfeinzimer
changed the title
action parameter, add proxy parameter action parameter, add mapViewProxy parameter, support rotation animation
dfeinzimer
changed the title
action parameter, add mapViewProxy parameter, support rotation animationaction parameter, add mapViewProxy parameter, support rotation animation
mhdostal
previously approved these changes
Apr 12, 2023
rolson
previously approved these changes
Apr 12, 2023
Merged
Co-authored-by: Mark Dostal <[email protected]>
Co-authored-by: Philip Ridgeway <[email protected]>
[Compass] Re-think API
mhdostal
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.