[client] Remove duplicate header #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
approved these changes
Sep 3, 2020
smyrick
changed the title
smyrick
added
changes: patch
|
@MarkusLund Thanks for the PR! Can you also make the same update to the |
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 3, 2020
Copying changes from ExpediaGroup#865
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 3, 2020
Copy changes from ExpediaGroup#865
smyrick
added a commit
that referenced
this pull request
Sep 3, 2020
Copy changes over from #865 to `3.x.x` branch
smyrick
added a commit
that referenced
this pull request
Sep 4, 2020
This header is already added with `install(JsonFeature) { }`
See #865
dariuszkuc
pushed a commit
that referenced
this pull request
Sep 4, 2020
* Remove duplicate accept header
This header is already added with `install(JsonFeature) { }`
See #865
* Update GraphQLKtorClient.kt
smyrick
added a commit
that referenced
this pull request
Sep 4, 2020
* Remove duplicate header Copy changes over from #865 to `3.x.x` branch * Update GraphQLClient.kt * Update GraphQLClient.kt
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Oct 16, 2020
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Oct 16, 2020
* Remove duplicate accept header
This header is already added with `install(JsonFeature) { }`
See ExpediaGroup#865
* Update GraphQLKtorClient.kt
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Remove duplicate accept header
This header is already added with `install(JsonFeature) { }`
See ExpediaGroup#865
* Update GraphQLKtorClient.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
It looks like the application/json accept header is set by
install(feature = JsonFeature)on line 48 as well asaccept(ContentType.Application.Json)on line 54. This causes a duplicate Accept header during the introspection query Gradle task.Spring handles the duplicate Accept header, but Jersey returns an 400 Bad Request when receiving the header.
Accept: application/json;application/json🔗 Related Issues
I have not created an issue.