[3.x.x][client] Remove duplicate header #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy changes over from #865 to `3.x.x` branch
smyrick
added
type: bug
tapaderster
approved these changes
Sep 3, 2020
|
Pretty sure we will have to remove it from the client as well -> https://github.com/ExpediaGroup/graphql-kotlin/blob/3.x.x/graphql-kotlin-client/src/main/kotlin/com/expediagroup/graphql/client/GraphQLClient.kt#L85 |
smyrick
changed the title
dariuszkuc
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Copy changes over to
3.x.xbranchIt looks like the application/json accept header is set by
install(feature = JsonFeature)on line 48 as well asaccept(ContentType.Application.Json)on line 54. This causes a duplicate Accept header during the introspection query Gradle task.Spring handles the duplicate Accept header, but Jersey returns an 400 Bad Request when receiving the header.
Accept: application/json;application/json🔗 Related Issues
#865