Skip to content

add test for utf8 issue (497) #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

pjfanning
Copy link
Member

@pjfanning
Copy link
Member Author

pjfanning commented Feb 20, 2025

@yawkat could you review if you have time?

@cowtowncoder - GitHub CI is refusing to run the CI due to exceeding costs and bills - I thought the CI was free for open source (maybe within limits). - see https://github.com/FasterXML/jackson-dataformats-text/actions/runs/13443367760

@cowtowncoder
Copy link
Member

@yawkat could you review if you have time?

@cowtowncoder - GitHub CI is refusing to run the CI due to exceeding costs and bills - I thought the CI was free for open source (maybe within limits). - see https://github.com/FasterXML/jackson-dataformats-text/actions/runs/13443367760

I actually even pay for FasterXML, fwtw. So not sure what racked up costs. Maybe newish cascading rebuilds...

@cowtowncoder cowtowncoder merged commit 0b200f4 into FasterXML:2.19 Feb 25, 2025
4 checks passed
@pjfanning pjfanning deleted the toml-497 branch February 25, 2025 13:02
@pjfanning
Copy link
Member Author

I suspect the cascading rebuilds are a factor. It might be cheaper to run builds on the a daily or weekly schedule (ie once a day or once a week).

@cowtowncoder
Copy link
Member

cowtowncoder commented Feb 25, 2025

Yeah it'd be cheaper but from usability perspective quicker feedback loop is pretty valuable -- esp. when there are multiple merges per day. Daily might still work, weekly has too slow feedback loop for sure.

But will keep my eyes peeled for usage; this is first time I've noticed running out of quote so not yet a big problem I think.

pjfanning added a commit to pjfanning/jackson-dataformats-text that referenced this pull request Feb 26, 2025
cowtowncoder pushed a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants