Skip to content

implement ns deletion #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

implement ns deletion #89

merged 1 commit into from
Apr 2, 2025

Conversation

jxs1211
Copy link
Contributor

@jxs1211 jxs1211 commented Apr 2, 2025 •
edited
Loading

Implement namespace deletion for #79

Flux159
Flux159 reviewed Apr 2, 2025
View reviewed changes
Copy link
Owner

@Flux159 Flux159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, there's some test updates because of how the k8s api returns while the namespace is still terminating.

@jxs1211
implement ns deletion
a7e9e38 
Signed-off-by: shenxianjie <[email protected]>
@Flux159 Flux159 merged commit 74a6818 into Flux159:main Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flux159 Flux159 Flux159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxs1211 @Flux159