Skip to content

implement ns deletion #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import { KubernetesManager } from "./types.js";
import { serverConfig } from "./config/server-config.js";
import { createDeploymentSchema } from "./config/deployment-config.js";
import { listNamespacesSchema } from "./config/namespace-config.js";
import { deleteNamespace, deleteNamespaceSchema } from "./tools/delete_namespace.js";
import { cleanupSchema } from "./config/cleanup-config.js";
import { startSSEServer } from "./utils/sse.js";
import {
Expand All @@ -58,7 +59,7 @@ import {
stopPortForward,
StopPortForwardSchema,
} from "./tools/port_forward.js";
import { deleteDeployment } from "./tools/delete_deployment.js";
import { deleteDeployment, deleteDeploymentSchema } from "./tools/delete_deployment.js";
import { createDeployment } from "./tools/create_deployment.js";
import {scaleDeployment,scaleDeploymentSchema} from "./tools/scale_deployment.js"
import {
Expand Down Expand Up @@ -86,6 +87,8 @@ server.setRequestHandler(ListToolsRequestSchema, async () => {
createPodSchema,
createCronJobSchema,
deletePodSchema,
deleteDeploymentSchema,
deleteNamespaceSchema,
describeCronJobSchema,
describePodSchema,
describeDeploymentSchema,
Expand Down Expand Up @@ -379,6 +382,16 @@ server.setRequestHandler(
);
}

case "delete_namespace": {
return await deleteNamespace(
k8sManager,
input as {
name: string;
ignoreNotFound?: boolean;
}
);
}

case "delete_deployment": {
return await deleteDeployment(
k8sManager,
Expand Down
4 changes: 4 additions & 0 deletions src/models/response-schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ export const CreateNamespaceResponseSchema = z.object({
content: z.array(ToolResponseContent),
});

export const DeleteNamespaceResponseSchema = z.object({
content: z.array(ToolResponseContent),
});

export const CreatePodResponseSchema = z.object({
content: z.array(ToolResponseContent),
});
Expand Down
57 changes: 57 additions & 0 deletions src/tools/delete_namespace.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import { KubernetesManager } from "../types.js";

export const deleteNamespaceSchema = {
name: "delete_namespace",
description: "Delete a Kubernetes namespace",
inputSchema: {
type: "object",
properties: {
name: { type: "string" },
ignoreNotFound: { type: "boolean", default: false },
},
required: ["name"],
},
} as const;

export async function deleteNamespace(k8sManager: KubernetesManager, input: {
name: string;
ignoreNotFound?: boolean;
}) {
try {
await k8sManager.getCoreApi().deleteNamespace(input.name);
return {
content: [
{
type: "text",
text: JSON.stringify(
{
success: true,
status: "deleted",
},
null,
2
),
},
],
};
} catch (error: any) {
if (input.ignoreNotFound && error.response?.statusCode === 404) {
return {
content: [
{
type: "text",
text: JSON.stringify(
{
success: true,
status: "not_found",
},
null,
2
),
},
],
};
}
throw error;
}
}
72 changes: 71 additions & 1 deletion tests/namespace.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect, test, describe, beforeEach, afterEach } from "vitest";
import { Client } from "@modelcontextprotocol/sdk/client/index.js";
import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js";
import { CreateNamespaceResponseSchema } from "../src/models/response-schemas";
import { CreateNamespaceResponseSchema, DeleteNamespaceResponseSchema } from "../src/models/response-schemas";
import { KubernetesManager } from "../src/utils/kubernetes-manager.js";

async function sleep(ms: number): Promise<void> {
Expand Down Expand Up @@ -83,4 +83,74 @@ describe("kubernetes server operations", () => {
const k8sManager = new KubernetesManager();
await k8sManager.getCoreApi().deleteNamespace(TEST_NAMESPACE_NAME);
});

test("delete namespace", async () => {
const TEST_NAMESPACE_NAME = "test-namespace-mcp-server2";
// Create namespace before test
const k8sManager = new KubernetesManager();
const result = await client.request(
{
method: "tools/call",
params: {
name: "create_namespace",
arguments: {
name: TEST_NAMESPACE_NAME,
},
},
},
CreateNamespaceResponseSchema
);
expect(result).toEqual({
content: [
{
type: "text",
text: JSON.stringify(
{
podName: TEST_NAMESPACE_NAME,
status: "created",
},
null,
2
),
},
],
});
// Wait for namespace to be fully created
await sleep(2000);
const result2 = await client.request(
{
method: "tools/call",
params: {
name: "delete_namespace",
arguments: {
name: TEST_NAMESPACE_NAME,
},
},
},
DeleteNamespaceResponseSchema,
);
expect(result2).toEqual({
content: [
{
type: "text",
text: JSON.stringify(
{
success: true,
status: "deleted",
},
null,
2
),
}
]
})

// verify namespace is deleted
const namespace = await k8sManager.getCoreApi().readNamespace(TEST_NAMESPACE_NAME);
if (namespace.body) {
expect(namespace.body.status?.phase).toBe("Terminating");
} else {
expect(namespace.body).toBeUndefined();
}
})
});