Skip to content

useNonce, usePCKE, and prefersEphemeralSession always false on iOS (and Mac Catalyst) #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shirakaba opened this issue Jul 22, 2024 · 0 comments · Fixed by #1000
Closed

Comments

@shirakaba
Copy link
Contributor

shirakaba commented Jul 22, 2024

Issue

On iOS (and Mac Catalyst), for the authorize() function, all boolean values passed from JS (namely useNonce, usePCKE, and prefersEphemeralSession) are marshalled incorrectly into Objective-C.

The method signatures all specify (Bool *) instead of (Bool) (example), so React Native marshals both true and false (from JS) to NO (Obj-C).


Environment

  • Your Identity Provider: Not sure, but affects all.
  • Platform that you're experiencing the issue on: iOS (and Mac Catalyst)
  • Your react-native Version: 0.73.1
  • Your react-native-app-auth Version: 7.2.0
  • Are you using Expo?: Yes

This was noticed in this issue: #980 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant