fix(ios): marshal booleans correctly (#999, #980) #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d1a93e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shirakaba
changed the title
|
Could you let me know the approximate date for the publication of these changes and the release of the new version of the react-native-app-auth library? |
zibs
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks a lot @shirakaba -- this looks good and seemed to work in my testing!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #999 and #980
Description
Changes the method signatures from
(BOOL *)(which marshals bothtrueandfalsefrom JS toNOin Objective-C) to(BOOL)(which correctly marshalstruetoYESandfalsetoNO).Steps to verify
authorizemethod.useNonce = truefrom JavaScript now becomesYESinstead ofNO.