Fixes several typos #520
Merged
Fixes several typos #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWessel
approved these changes
Mar 16, 2019
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
…ericMappingTools#520) Used to insert 1D numpy arrays of string type from PyGMT directly into GMT via the C API. * Set valid GMT data mode as GMT_IS_OUTPUT * Try passing "GMT_IS_VECTOR" family type to put_strings * Do `put_vector` x and y before `put_strings` s, dim is 2 only * Try using ctypes.POINTER in argtypes of c_put_strings * Pass strings using "GMT_IS_VECTOR|GMT_IS_DUPLICATE" * Add test for passing in one string column to virtualfile_from_vectors * Fix test_plot_datetime by not passing first two columns into put_strings * Refactor virtualfile_from_vectors to handle any number of string type columns * Test for put_strings failing to increase code coverage * Expect failures for tests using GMT_Put_strings on GMT < 6.1.1 * Concatenate last string columns instead of allowing arbitrary positions * Test variable length strings * Replace gmt info with convert in test_virtualfile_from_vectors_str_cols Co-authored-by: Dongdong Tian <[email protected]>
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
* Remove note on shift_origin added in GenericMappingTools#536 * Remove xfails for put_strings added in GenericMappingTools#520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several common typos in both the source codes and documentations.
These typos are fixed automatically by codespell and then manually inspected.