Improve parsing of modifier text with plus-symbols #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since quotes are not passed into GMT, it can be difficult to know if any combination of +letter is a modifier or not. To eliminate as many cases as we can, we do this: For argument to an option that takes modifiers, replace any + symbol that is not followed by one of the allowed modifier letters with ASCII 1. New: THe second time we find a + followed by a valid modifier we know it cannot be a modifer since a modifier can only be given once. So +tTitle+test will now handle the second +t sequence as plain text. Bug: If a string ended in a plus then it got removed. With these improvements we are less vulnerable to this problem and a few tests could be simplified and a few actually had text ending in double-pus-symbols to compensate for the loss of the last. Ultimately, the only foolproof way to not have a +letter be interpreted as a modifier is to use the octal code for the plus: \053.
seisman
approved these changes
Mar 25, 2019
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
* Remove note on shift_origin added in GenericMappingTools#536 * Remove xfails for put_strings added in GenericMappingTools#520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since quotes are not passed into GMT, it can be difficult to know if any combination of +letter is a modifier or not. To eliminate as many cases as we can, we run this check before parsing:
With these improvements we are less vulnerable to this problem and a few tests could be simplified and a few actually had text ending in double-pus-symbols to compensate for the loss of the last plus. Ultimately, the only foolproof way to not have a +letter be interpreted as a modifier is to use the octal code for the plus: \053.
Closes #576.