CI: Do not use geopandas 0.13.0 in docs #2545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
weiji14
approved these changes
May 26, 2023
|
Upstream issue opened at geopandas/geopandas#2908. For reference, this was the traceback from the readthedocs build failure: Unexpected failing examples:
/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/checkouts/2536/examples/gallery/lines/roads.py failed leaving traceback:
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/checkouts/2536/examples/gallery/lines/roads.py", line 16, in <module>
gdf = gpd.read_file(
^^^^^^^^^^^^^^
File "/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/conda/2536/lib/python3.11/site-packages/geopandas/io/file.py", line 248, in _read_file
return _read_file_fiona(
^^^^^^^^^^^^^^^^^
File "/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/conda/2536/lib/python3.11/site-packages/geopandas/io/file.py", line 289, in _read_file_fiona
with reader(path_or_bytes, **kwargs) as features:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/conda/2536/lib/python3.11/site-packages/fiona/env.py", line 457, in wrapper
return f(*args, **kwds)
^^^^^^^^^^^^^^^^
File "/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/conda/2536/lib/python3.11/site-packages/fiona/__init__.py", line 336, in open
colxn = Collection(
^^^^^^^^^^^
File "/home/docs/checkouts/readthedocs.org/user_builds/pygmt-dev/conda/2536/lib/python3.11/site-packages/fiona/collection.py", line 243, in __init__
self.session.start(self, **kwargs)
File "fiona/ogrext.pyx", line 588, in fiona.ogrext.Session.start
File "fiona/ogrext.pyx", line 143, in fiona.ogrext.gdal_open_vector
fiona.errors.DriverError: '/vsizip/vsicurl/http://www2.census.gov/geo/tiger/TIGER2015/PRISECROADS/tl_2015_15_prisecroads.zip' does not exist in the file system, and is not recognized as a supported dataset name. |
|
This is a bit strange: while working on fixing the mentioned issue, this specific URL actually does work for me with geopandas 0.13.0: and also works with So for this specific url, it might be related to the GDAL version? (or maybe a temporary server issue?) |
7 tasks
Hmm you're right. I just tested installing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As mentioned in #2536 (comment), our docs CI fail due to changes with the geopandas 0.13.0 release (geopandas/geopandas#2796 (comment)), which is an unexpected regression.
Before the next geopandas patch version is released, we need to skip geopandas 0.13.0 in the docs workflow so that the docs can be correctly built and updated.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version