Skip to content

Unpin geopandas 0.13.0 in CI docs build #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jun 8, 2023

Description of proposed changes

The issue of reading zip files from URLs should have been resolved in geopandas>=0.13.1, see geopandas/geopandas@v0.13.0...v0.13.2

Preview at https://pygmt-dev--2568.org.readthedocs.build/en/2568/gallery/lines/roads.html#sphx-glr-gallery-lines-roads-py

Reverts #2545

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

The issue of reading zip files from URLs should have been resolved in geopandas>=0.13.1, see geopandas/geopandas@v0.13.0...v0.13.2
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jun 8, 2023
@weiji14 weiji14 added this to the 0.10.0 milestone Jun 8, 2023
@weiji14 weiji14 self-assigned this Jun 8, 2023
@weiji14
Copy link
Member Author

weiji14 commented Jun 8, 2023

Hold on, the Readthedocs build at https://readthedocs.org/projects/pygmt-dev/builds/20952470/ seems to be stuck.

Edit: Readthedocs build completed. Can confirm that the example downloading the zip file at https://pygmt-dev--2568.org.readthedocs.build/en/2568/gallery/lines/roads.html#sphx-glr-gallery-lines-roads-py works now.

@weiji14 weiji14 marked this pull request as ready for review June 8, 2023 10:06
@seisman seisman merged commit 4f2c7f4 into main Jun 8, 2023
@seisman seisman deleted the ci-docs/unpin-geopandas branch June 8, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants