Skip to content

Run style checks using GitHub Actions instead of Azure Pipelines #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 12, 2020
Merged

Run style checks using GitHub Actions instead of Azure Pipelines #519

merged 7 commits into from
Jul 12, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 12, 2020 •
edited by weiji14
Loading

Description of proposed changes

This PR implements style checks in github actions. We no longer need Azure Pipelines.

Continuation of #513. Closes #443.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@vercel vercel bot temporarily deployed to Preview July 12, 2020 06:12 Inactive
@vercel vercel bot temporarily deployed to Preview July 12, 2020 06:19 Inactive
@seisman
Run style checks in GitHub Actions
185a8c6 
Also remove Azure Pipelines.
@seisman seisman requested review from leouieda and weiji14 July 12, 2020 06:20
weiji14
weiji14 reviewed Jul 12, 2020
View reviewed changes
@weiji14
Copy link
Member

weiji14 commented Jul 12, 2020

Now would be a good time to update our maintenance guide at https://github.com/GenericMappingTools/pygmt/blob/v0.1.2/MAINTENANCE.md#continuous-integration. I can help out with that if it's getting late for you.

@seisman
Copy link
Member Author

seisman commented Jul 12, 2020

Feel free to make any changes to this PR.

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Jul 12, 2020
@weiji14 weiji14 changed the title Run style checks in GitHub Actions Run style checks in GitHub Actions instead of Azure Pipelines Jul 12, 2020
@weiji14 weiji14 mentioned this pull request Jul 12, 2020
Closed
@weiji14 weiji14 changed the title Run style checks in GitHub Actions instead of Azure Pipelines Run style checks using GitHub Actions instead of Azure Pipelines Jul 12, 2020
weiji14
weiji14 approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the tests from style_check.yaml to ci_tests.yaml to keep things in one place (similar to Azure Pipelines before). Should be good to merge but feel free to take another look.

@seisman seisman marked this pull request as ready for review July 12, 2020 16:43
@seisman seisman added this to the 0.2.x milestone Jul 12, 2020
@seisman seisman merged commit 216f5d2 into master Jul 12, 2020
@seisman seisman deleted the style-check branch July 12, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@leouieda leouieda Awaiting requested review from leouieda

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Update the maintainers guide
2 participants
@seisman @weiji14