Skip to content

Run style checks using GitHub Actions instead of Azure Pipelines #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 12, 2020
Merged

Run style checks using GitHub Actions instead of Azure Pipelines #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
185a8c6
Run style checks in GitHub Actions
seisman Jul 11, 2020
1a80311
Update Continuous Integration maintenance note to include GH Actions
weiji14 Jul 12, 2020
0b77a19
Remove Style Checks badge from README.rst
weiji14 Jul 12, 2020
7040eb1
Move style checks job into ci_tests.yaml
weiji14 Jul 12, 2020
fd1d26d
Use pip instead of conda to install black flake8 and pylint
weiji14 Jul 12, 2020
8e21bb6
Run style checks using default bash shell
weiji14 Jul 12, 2020
29d3947
No need to use login shell
seisman Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions .azure-pipelines.yml
View file
Open in desktop

This file was deleted.

24 changes: 24 additions & 0 deletions .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,30 @@ on:
- cron: '0 0 * * *'

jobs:
style_check:
name: Style Checks
runs-on: ubuntu-latest

steps:
# Checkout current git repository
- name: Checkout
uses: actions/[email protected]

# Setup Miniconda
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.7

- name: Install packages
run: pip install black flake8 pylint

- name: Formatting check (black and flake8)
run: make check

- name: Linting (pylint)
run: make lint

test:
name: ${{ matrix.os }} - Python ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
Expand Down
9 changes: 5 additions & 4 deletions MAINTENANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,11 @@ The main advantages of this are:

## Continuous Integration

We use TravisCI continuous integration (CI) services to build and test the
project on Linux, and Mac (Windows is still a work in progress).
The configuration file for this service is `.travis.yml`.
It relies on the `requirements.txt` file to install the required dependencies using
We use Github Actions and TravisCI continuous integration (CI) services to
build and test the project on Linux, macOS and Windows.
The configuration file for these services are in
`.github/workflows/ci_tests.yaml` and `.travis.yml`.
They rely on the `requirements.txt` file to install required dependencies using
conda and the `Makefile` to run the tests and checks.

Travis also handles all of our deployments automatically:
Expand Down
3 changes: 0 additions & 3 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ PyGMT
.. image:: http://img.shields.io/travis/GenericMappingTools/pygmt/master.svg?style=flat-square&label=Linux
:alt: Travis CI build status
:target: https://travis-ci.org/GenericMappingTools/pygmt
.. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square
:alt: Azure Pipelines build status
:target: https://dev.azure.com/GenericMappingTools/PyGMT/_build
.. image:: https://github.com/GenericMappingTools/pygmt/workflows/Tests/badge.svg
:alt: GitHub Actions build status
:target: https://github.com/GenericMappingTools/pygmt/actions
Expand Down