Skip to content

Disable Express eTag response header for consistent FF behaviour across FF runtimes #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

Disable Express eTag response header for consistent FF behaviour across FF runtimes #433

merged 2 commits into from
Mar 31, 2022

Conversation

cstanger
Copy link
Contributor

@cstanger cstanger commented Mar 25, 2022 •
edited
Loading

The Express.js framework handles [eTags] (https://expressjs.com/en/api.html#app.settings.table) by default. Therefore, will respond with HTTP 304 Not Modified when a known eTag header value is present in a request with the same response.

In all other Function Framework runtime implementations, this behavior is not implemented, and this caching behavior, which can be considered as an implementation detail, could be explicitly addressed by a developer as needed.

This pull request aims make the NodeJs runtime version behaving the same as runtime implementations for GO, Java, Ruby, .Net Core, Python, and PHP.

@cstanger cstanger changed the title Disable Express eTag response header for conistant FF behaviour across FF runtimes Disable Express eTag response header for consistent FF behaviour across FF runtimes Mar 25, 2022
grant
grant approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍🏻 I've also checked the docs and occurrences elsewhere.

@grant grant mentioned this pull request Mar 28, 2022
Merged
@grant grant added the automerge Summon MOG for automerging label Mar 31, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 195ae30 into GoogleCloudPlatform:master Mar 31, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Mar 31, 2022
grant added a commit that referenced this pull request Mar 31, 2022
@grant
Revert "Disable Express eTag response header for consistent FF behavi…
6feac82 
…our across FF runtimes (#433)"

This reverts commit 195ae30.
@grant grant mentioned this pull request Mar 31, 2022
Merged
grant added a commit that referenced this pull request Mar 31, 2022
@grant
Revert "Disable Express eTag response header for consistent FF behavi…
957320b 
…our across FF runtimes (#433)" (#438)

This reverts commit 195ae30.
grant added a commit that referenced this pull request Mar 31, 2022
@grant
Revert "Revert "Disable Express eTag response header for consistent F…
6f466e4 
…F behaviour across FF runtimes (#433)" (#438)"

This reverts commit 957320b.
@grant grant mentioned this pull request Mar 31, 2022
Merged
grant added a commit that referenced this pull request Mar 31, 2022
@grant
feat: Disable Express eTag response header for consistent FF behaviou…
07668f6 
…r across FF runtimes (#439)

* Revert "Revert "Disable Express eTag response header for consistent FF behaviour across FF runtimes  (#433)" (#438)"

This reverts commit 957320b.

* lint: update newlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cstanger @grant