Skip to content

Disable Express eTag response header for consistent FF behaviour across FF runtimes #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Disable Express eTag response header for consistent FF behaviour across FF runtimes #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5bceb
perf: disable Express eTag response header
cstanger Mar 25, 2022
cd4d23c
docs: minor comment
grant Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,13 @@ export function getServer(
// Subsequent parsers will be skipped when one is matched.
app.use(bodyParser.raw(rawBodySavingOptions));
app.enable('trust proxy'); // To respect X-Forwarded-For header.

// Disable Express 'x-powered-by' header:
// http://expressjs.com/en/advanced/best-practice-security.html#at-a-minimum-disable-x-powered-by-header
app.disable('x-powered-by');

// Disable Express eTag response header
app.disable('etag');

if (
functionSignatureType === 'event' ||
Expand Down