Skip to content

ci: use flakybot with actions workflows #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 7, 2023
Merged

ci: use flakybot with actions workflows #3079

merged 36 commits into from
Apr 7, 2023

Conversation

kweinmeister
Copy link
Collaborator

@kweinmeister kweinmeister commented Mar 11, 2023 •
edited
Loading

  • Enable FlakyBot to run on Actions workflows. Right now, it is only uploading logs for Kokoro-based workflows, because it isn't using the xunit based runner and exporting to a log file for upload to FlakyBot.
  • Upgrade to FlakyBot 1.2
  • Use reusable workflows, for improved modularity when adding FlakyBot steps
  • In this first PR, it is only enabled for one service, scheduler. In a second PR, it can be applied to other workflows.
  • Tested and confirmed that a flaky issue was created: scheduler: should create a scheduler job failed #3077

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Mar 11, 2023
@kweinmeister kweinmeister marked this pull request as ready for review March 11, 2023 22:59
@kweinmeister kweinmeister requested review from a team as code owners March 11, 2023 22:59
sofisl
sofisl approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@sofisl sofisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to configure flakybot via github actions, but it's definitely not going to break anything!

@kweinmeister kweinmeister requested a review from a team March 15, 2023 19:38
@kweinmeister
Copy link
Collaborator Author

FYI @averikitsch in case you have any additional feedback from a GitHub Actions perspective.

@kweinmeister kweinmeister merged commit bb962b8 into main Apr 7, 2023
@kweinmeister kweinmeister deleted the flakybot-actions branch April 7, 2023 16:10
This was referenced Apr 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kweinmeister @averikitsch @sofisl @pattishin