-
Notifications
You must be signed in to change notification settings - Fork 2k
ci: use flakybot with matrix workflows #3112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI @averikitsch @pattishin, in case you can take a look. This rolls out #3079 to an initial set of samples, which were using a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few recommendations.
Thanks for the very helpful suggestions! |
Refactored the 5
functions
workflows that currently use a matrix strategy, to use a common workflow template that includes FlakyBot 1.2+.Considerations:
Changes:
ci-matrix.yaml.njk
workflows-matrix.json
array of workflows using a matrix strategy was created. These workflows require the workflow developer to manually specify the subdirectories that need to be tested within them. So, they shouldn't be included along with all of the other workflows that can be safely automatically generated.generate.js
to specify the matrix template.functions/concepts
samples are small gists that do not have tests. To enable using the reusabletest.yaml
, a no-opnpm test
script was added.