Change to endpoints managed rollout #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonz130
added
the
do not merge
googlebot
added
the
cla: yes
added 2 commits
March 7, 2018 18:44
fixing bookstore.yaml
wmwong
suggested changes
Mar 27, 2018
| @@ -44,7 +44,7 @@ spec: | |||
| "--http2_port=9000", | |||
| "--backend=grpc://127.0.0.1:50051", | |||
| "--service=SERVICE_NAME", | |||
| "--version=SERVICE_CONFIG_ID", | |||
| "--rollout_strategy==managed", | |||
| @@ -95,7 +95,6 @@ Cloud account and [SDK](https://cloud.google.com/sdk/) configured. | |||
| ```bash | |||
There was a problem hiding this comment.
Up above after "gcloud endpoints services deploy ...":
- Remove comment about noting the config ID.
- Remove command about getting the config ID.
added 2 commits
March 27, 2018 18:35
Fixing managed rollout typo with extra =
simonz130
removed
the
do not merge
simonz130
changed the title
andrewsg
approved these changes
Mar 28, 2018
wmwong
approved these changes
Mar 28, 2018
| @@ -49,13 +49,10 @@ Cloud account and [SDK](https://cloud.google.com/sdk/) configured. | |||
|
|
|||
| ```bash | |||
| gcloud endpoints services deploy api_descriptor.pb api_config.yaml | |||
| # The Config ID should be printed out, looks like: 2017-02-01r0, remember this | |||
|
|
|||
| # Set your project ID as a variable to make commands easier: | |||
| GCLOUD_PROJECT=<Your Project ID> | |||
|
|
|||
There was a problem hiding this comment.
This blank line should probably also be removed.
There was a problem hiding this comment.
I think it's better to have the blank line - for better clarity of the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new feature where we can specify in YAML that service configuration for Endpoints is going to be managed. This means that the service will pull latest deployed service configuration automatically, rather than requiring customer to specify specific version of service configuration.
New flag:
--rollout_strategy=managed
Previously the only way to specify a version was using the following flag:
--version=SERVICE_CONFIG_ID