Skip to content

Change to endpoints managed rollout #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions endpoints/getting-started-grpc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ Cloud account and [SDK](https://cloud.google.com/sdk/) configured.
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up above after "gcloud endpoints services deploy ...":

  • Remove comment about noting the config ID.
  • Remove command about getting the config ID.

GCLOUD_PROJECT=$(curl -s "http://metadata.google.internal/computeMetadata/v1/project/project-id" -H "Metadata-Flavor: Google")
SERVICE_NAME=hellogrpc.endpoints.${GCLOUD_PROJECT}.cloud.goog
SERVICE_CONFIG_ID=<Your Config ID>
```

1. Pull your credentials to access Container Registry, and run your gRPC server
Expand All @@ -114,7 +113,7 @@ Cloud account and [SDK](https://cloud.google.com/sdk/) configured.
--link=grpc-hello:grpc-hello \
gcr.io/endpoints-release/endpoints-runtime:1 \
--service=${SERVICE_NAME} \
--version=${SERVICE_CONFIG_ID} \
--rollout_strategy=managed \
--http2_port=9000 \
--backend=grpc://grpc-hello:50051
```
Expand Down Expand Up @@ -146,19 +145,11 @@ Cloud account and [SDK](https://cloud.google.com/sdk/) configured.
gcloud container clusters create my-cluster --zone=us-central1-a
```

1. Edit `deployment.yaml`. Replace `SERVICE_NAME`, `SERVICE_CONFIG_ID`,
and `GCLOUD_PROJECT` with your values:
1. Edit `deployment.yaml`. Replace `SERVICE_NAME` and `GCLOUD_PROJECT` with your values:

`SERVICE_NAME` is equal to hellogrpc.endpoints.GCLOUD_PROJECT.cloud.goog,
replacing GCLOUD_PROJECT with your project ID.

`SERVICE_CONFIG_ID` can be found by running the following command, replacing
GCLOUD_PROJECT with your project ID.

```bash
gcloud endpoints configs list --service hellogrpc.endpoints.GCLOUD_PROJECT.cloud.goog
```

1. Deploy to GKE:

```bash
Expand Down
2 changes: 1 addition & 1 deletion endpoints/getting-started-grpc/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
"--http2_port=9000",
"--backend=grpc://127.0.0.1:50051",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
"--rollout_strategy==managed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "==" to "=".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

]
ports:
- containerPort: 9000
Expand Down
2 changes: 1 addition & 1 deletion endpoints/getting-started/app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ endpoints_api_service:
# The following values are to be replaced by information from the output of
# 'gcloud endpoints services deploy openapi-appengine.yaml' command.
name: ENDPOINTS-SERVICE-NAME
config_id: ENDPOINTS-CONFIG-ID
rollout_strategy: managed
# [END configuration]
2 changes: 1 addition & 1 deletion endpoints/getting-started/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
"--http_port=8081",
"--backend=127.0.0.1:8080",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
"--rollout_strategy=managed",
]
# [END esp]
ports:
Expand Down
2 changes: 1 addition & 1 deletion endpoints/kubernetes/grpc-bookstore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
args: [
"--http2_port=9000",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
"--rollout_strategy=managed",
"--backend=grpc://127.0.0.1:8000"
]
ports:
Expand Down