Skip to content

chore: remove BigQuery cloud-client samples #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 31, 2020
Merged

chore: remove BigQuery cloud-client samples #4179

merged 8 commits into from
Jul 31, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 26, 2020

Do not merge until googleapis/python-bigquery#148, as well as an internal PR that will redirect the BigQuery docs to point to the new samples location (TODO: somebody please open that PR).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 6, 2020
@plamut plamut force-pushed the remove-bigquery-samples branch from 216b859 to 86d47b9 Compare July 23, 2020 07:31
@plamut
Copy link
Contributor Author

plamut commented Jul 23, 2020

Samples have been moved to the BigQuery repo: googleapis/python-bigquery#174

We need to point the docs at cloud.google.com to the new location before merging this.

@plamut plamut marked this pull request as ready for review July 23, 2020 07:33
@plamut plamut requested review from shollyman and a team as code owners July 23, 2020 07:33
@shollyman
Copy link
Contributor

I'll work on doing the docsite internal change today to re-point all the embeds.

@shollyman
Copy link
Contributor

tracking internally as 162000215

shollyman
shollyman approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, docs should be repointed.

tmatsuo
tmatsuo suggested changes Jul 23, 2020
View reviewed changes
@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 23, 2020
@busunkim96 busunkim96 requested a review from tmatsuo July 24, 2020 00:37
@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 25, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@plamut
Copy link
Contributor Author

plamut commented Jul 31, 2020 •
edited
Loading

What's the status of this, can somebody please re-run the tests (the status appears stalled)?
Thanks!

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 31, 2020
@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 31, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
@busunkim96 busunkim96 merged commit f0a8ffa into GoogleCloudPlatform:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

@tmatsuo tmatsuo Awaiting requested review from tmatsuo

Assignees

@tmatsuo tmatsuo

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@plamut @shollyman @tmatsuo @busunkim96 @googlebot @leahecole @kokoro-team