docs: add samples from bigquery/cloud-client #174

plamut · 2020-07-21T14:00:22Z

Samples from https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/bigquery/cloud-client

IMPORTANT: When merging, use the rebase and merge option to preserve the samples commit history!

NOTE: There are also other bigquery-related samples in the samples repo. If any others besides cloud-client need to be moved here, please let me know and I'll open additional PRs.

Closes #149.
Towards #147.
Supersedes #148 (regenerates latest samples from scratch).

google-cla · 2020-07-21T14:01:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-07-21T14:40:32Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-07-21T15:05:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

plamut · 2020-07-21T15:55:39Z

I would need some CI insight here, I can't see the samples log to see why those checks failed. Are the failures the same as in the "samples" session of the main noxfile?

Importing IPython fails, even though it was added to samples dependencies and samples tests pass locally (using the samples/snippets noxfile). Ditto for the missing GOOGLE_CLOUD_PROJECT env variable.

Also, should the snippets session now be removed from the main noxfile?

busunkim96 · 2020-07-21T17:49:22Z

CI seems to be falling over during the setup stage. This usually happens when the path to the build script is misconfigured.

[08:05:42] FATAL: Build script missing in checked out sources
[08:05:42] Failed to start execution
[08:05:42] hudson.AbortException: Build script does not exist: /tmp/workspace/workspace/cloud-devrel/client-libraries/python/googleapis/python-bigquery/samples/python3.6/presubmit/src/github/python-bigquery/.kokoro/trampoline.sh

Will submit a PR to fix this, once I've figured out which config it is 😄

busunkim96 · 2020-07-21T18:39:45Z

@plamut Once all the samples are being tested via a samples noxfile you can delete the extra session in the main noxfile.

That said, I see there are existing samples in the base samples directory. Is it okay to move those into the samples/snippets directory so they get tested? Should they be grouped into some other directory? @shollyman

shollyman · 2020-07-21T21:38:34Z

Yeah, we'll need to move the existing samples. Happy to do this in a subsequent PR, since it also means we need to update all the include paths in the documentation site.

google-cla · 2020-07-22T06:39:13Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

plamut · 2020-07-22T06:45:39Z

It turned out that tests in samples/snippets were run by both the snippets session in the main noxfile and the py session in the local noxfile placed in that directory. Some of those tests failed, because the main session config sets up a slightly different environment.

A clean solution was to simply exclude samples/snippets from the main snippets run and moving the existing samples turned out to not even be necessary (at least for this particular PR). And we got rid of the test run duplication.

Side note - why does the CLA bot flip the label again even though the only new commits are mine, the PR sender, for which the bot already found the CLA?

google-cla · 2020-07-22T07:21:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-07-22T07:22:41Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-07-22T07:23:34Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…oudPlatform/python-docs-samples#3426) Co-authored-by: Leah E. Cole <[email protected]>

…latform/python-docs-samples#3190) Co-authored-by: Leah E. Cole <[email protected]>

…loudPlatform/python-docs-samples#3180) Co-authored-by: Leah E. Cole <[email protected]>

…udPlatform/python-docs-samples#3177) Co-authored-by: Leah E. Cole <[email protected]>

…49)](GoogleCloudPlatform/python-docs-samples#3049) * chore(deps): update dependency google-cloud-bigquery to v1.24.0 * chore(deps): update ipython version * fix: fix requirements order * explicitly add grpc to resolve errors * adjust arguments * undo mistake * bump auth version Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Leah Cole <[email protected]> Co-authored-by: Leah E. Cole <[email protected]> Co-authored-by: Christopher Wilcox <[email protected]>

…tform/python-docs-samples#3566)

…udPlatform/python-docs-samples#3670) Co-authored-by: Takashi Matsuo <[email protected]>

…CloudPlatform/python-docs-samples#3883) fixes #3882

…udPlatform/python-docs-samples#3917) Co-authored-by: Takashi Matsuo <[email protected]>

…udPlatform/python-docs-samples#4022)

…loudPlatform/python-docs-samples#4118) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [matplotlib](https://matplotlib.org) ([source](https://togithub.com/matplotlib/matplotlib)) | patch | `==3.2.1` -> `==3.2.2` | --- ### Release Notes <details> <summary>matplotlib/matplotlib</summary> ### [`v3.2.2`](https://togithub.com/matplotlib/matplotlib/releases/v3.2.2) [Compare Source](https://togithub.com/matplotlib/matplotlib/compare/v3.2.1...v3.2.2) This is the second bugfix release of the 3.2.x series. This release contains several critical bug-fixes: - support fractional HiDPI scaling with Qt backends - support new Python and fix syntax errors in legacy Python - support new Qt 5 and fix support for Qt 4 - fix animation writer fallback - fix figure resizing - fix handling of large arcs - fix issues with tight layout - fix saving figures after closing windows or under certain size conditions - fix scatter when specifying a single color - fix several memory leaks - fix unexpected autoscaling behavior - fix various issues with usetex - various minor bug and documentation fixes </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

…thon-docs-samples#4189) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ipython](https://ipython.org) ([source](https://togithub.com/ipython/ipython)) | minor | `==7.15.0` -> `==7.16.1` | --- ### Release Notes <details> <summary>ipython/ipython</summary> ### [`v7.16.1`](https://togithub.com/ipython/ipython/compare/7.16.0...7.16.1) [Compare Source](https://togithub.com/ipython/ipython/compare/7.16.0...7.16.1) ### [`v7.16.0`](https://togithub.com/ipython/ipython/compare/7.15.0...7.16.0) [Compare Source](https://togithub.com/ipython/ipython/compare/7.15.0...7.16.0) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

…Platform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <[email protected]>

…rm/python-docs-samples#4287) * chore(deps): update dependency mock to v4 * specify mock version for appengine python 2 Co-authored-by: Leah Cole <[email protected]>

…loudPlatform/python-docs-samples#4310)

google-cla · 2020-07-22T19:55:25Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

plamut · 2020-07-22T21:47:37Z

@busunkim96 @shollyman Please just flip the CLA label again, and I think we can merge this, yay. Thanks!

(had to manually rebase the entire branch, as GitHub did not allow me to "rebase and merge" due to a trivial conflict in one of the very old commits)

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 21, 2020

plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 21, 2020

plamut added the type: docs Improvement to the documentation for an API. label Jul 21, 2020

plamut mentioned this pull request Jul 21, 2020

docs: add samples from bigquery/cloud-client #148

Closed

plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 21, 2020

plamut requested review from busunkim96 and shollyman July 21, 2020 15:42

busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020

busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 21, 2020

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 22, 2020

plamut force-pushed the add-snippets-samples-2 branch from 3dbc5bf to 08b0ecb Compare July 22, 2020 07:20

plamut force-pushed the add-snippets-samples-2 branch from 08b0ecb to 5c70a0c Compare July 22, 2020 07:21

busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 22, 2020

shollyman approved these changes Jul 22, 2020

View reviewed changes

shollyman and others added 21 commits July 22, 2020 21:46

fix: address issues with concurrent BigQuery tests [(#3426)](GoogleCl…

706a39a

…oudPlatform/python-docs-samples#3426) Co-authored-by: Leah E. Cole <[email protected]>

chore(deps): update dependency pytz to v2019.3 [(#3190)](GoogleCloudP…

ed50bd9

…latform/python-docs-samples#3190) Co-authored-by: Leah E. Cole <[email protected]>

chore(deps): update dependency matplotlib to v3.2.1 [(#3180)](GoogleC…

e49124d

…loudPlatform/python-docs-samples#3180) Co-authored-by: Leah E. Cole <[email protected]>

chore(deps): update dependency ipython to v7.13.0 [(#3177)](GoogleClo…

e605e38

…udPlatform/python-docs-samples#3177) Co-authored-by: Leah E. Cole <[email protected]>

chore(deps): update dependency pytz to v2020 [(#3566)](GoogleCloudPla…

f4ad717

…tform/python-docs-samples#3566)

chore(deps): update dependency ipython to v7.14.0 [(#3670)](GoogleClo…

0e31768

…udPlatform/python-docs-samples#3670) Co-authored-by: Takashi Matsuo <[email protected]>

[bigquery] opt in to use the build specific projects [(#3883)](Google…

c1c87bd

…CloudPlatform/python-docs-samples#3883) fixes #3882

chore(deps): update dependency ipython to v7.15.0 [(#3917)](GoogleClo…

239ee4f

…udPlatform/python-docs-samples#3917) Co-authored-by: Takashi Matsuo <[email protected]>

Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleClo…

f97d6ce

…udPlatform/python-docs-samples#4022)

chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloud…

9a1cb6c

…Platform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <[email protected]>

chore(deps): update dependency mock to v4 [(#4287)](GoogleCloudPlatfo…

092370c

…rm/python-docs-samples#4287) * chore(deps): update dependency mock to v4 * specify mock version for appengine python 2 Co-authored-by: Leah Cole <[email protected]>

chore(deps): update dependency matplotlib to v3.3.0 [(#4310)](GoogleC…

f244bea

…loudPlatform/python-docs-samples#4310)

chore: update templates

dadc62a

chore: change project env variable to use in tests

660407e

chore: fix samples tests dependencies

25b636f

chore: exclude orphan samples doc files from TOC

6ca8cc6

chore: skip samples/snippets in top level snippets test

a42eff1

plamut force-pushed the add-snippets-samples-2 branch from 824862f to a42eff1 Compare July 22, 2020 19:54

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 22, 2020

shollyman added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 22, 2020

shollyman merged commit 1ec41ef into googleapis:master Jul 22, 2020

plamut mentioned this pull request Jul 23, 2020

chore: remove BigQuery cloud-client samples GoogleCloudPlatform/python-docs-samples#4179

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: add samples from bigquery/cloud-client #174

docs: add samples from bigquery/cloud-client #174

Uh oh!

plamut commented Jul 21, 2020 •

edited

Loading

Uh oh!

google-cla bot commented Jul 21, 2020

Uh oh!

google-cla bot commented Jul 21, 2020

Uh oh!

google-cla bot commented Jul 21, 2020

Uh oh!

plamut commented Jul 21, 2020 •

edited

Loading

Uh oh!

busunkim96 commented Jul 21, 2020

Uh oh!

busunkim96 commented Jul 21, 2020

Uh oh!

shollyman commented Jul 21, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

plamut commented Jul 22, 2020 •

edited

Loading

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

plamut commented Jul 22, 2020 •

edited

Loading

Uh oh!

Uh oh!

docs: add samples from bigquery/cloud-client #174

docs: add samples from bigquery/cloud-client #174

Uh oh!

Conversation

plamut commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Jul 21, 2020

Uh oh!

google-cla bot commented Jul 21, 2020

Uh oh!

google-cla bot commented Jul 21, 2020

Uh oh!

plamut commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

busunkim96 commented Jul 21, 2020

Uh oh!

busunkim96 commented Jul 21, 2020

Uh oh!

shollyman commented Jul 21, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

plamut commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

google-cla bot commented Jul 22, 2020

Uh oh!

plamut commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

plamut commented Jul 21, 2020 •

edited

Loading

plamut commented Jul 21, 2020 •

edited

Loading

plamut commented Jul 22, 2020 •

edited

Loading

plamut commented Jul 22, 2020 •

edited

Loading