refactor: typehints and return for webrisk samples #9966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
|
Webrisk has an existing noxfile config. Should that be updated? |
engelke
reviewed
May 16, 2023
No, you're right. That file already exists, and it already has Enforce Type Hints set to True, so this is fine. |
engelke
approved these changes
May 16, 2023
nicain
requested changes
May 16, 2023
kweinmeister
approved these changes
May 16, 2023
nicain
approved these changes
May 16, 2023
nicain
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
b/280881593 : Fix typehints and return responses from samples to tests.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)